This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(dropdown): make dropdown-append-to-body configurable #6356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 9, 2016 21:07
Make dropdown-append-to-body accept a value which will be evaluated to determine if the menu should be appended to body. If no value is specified, or a non-false value is specified then the menu will be appended to body. If the value is `false` then the menu will not be appended to body.
Only append and remove append-to and append-to-body menus when the menu is opened or closed. This allows for the values of append-to and append-to-body to be evaluated when the menu is toggled open, and also prevents littering of the DOM.
Instead of removing the dropdown-menu on close, append it back to the original element.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make dropdown-append-to-body accept a value which will be evaluated to
determine if the menu should be appended to body. If no value is
specified, or a non-false value is specified then the menu will be
appended to body. If the value is
falsethen the menu will not beappended to body.