Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Stop propagation when pressing ENTER or ESC key from dropdown #901

Merged

Conversation

loverajoel
Copy link
Contributor

What does this Pull Request Do?

Fix the event propagation when pressing enter or escape key from dropdown

How should this be manually tested?

Run the tests and try the demos

What are the relevant issues?

#862

@dlsso
Copy link

dlsso commented May 6, 2015

+1

1 similar comment
@Vitall
Copy link

Vitall commented May 7, 2015

+1

@t1mmen
Copy link

t1mmen commented May 9, 2015

Thanks for this @loverajoel, looking forward to it being merged!

@just-boris
Copy link
Contributor

+1
Once we make a component, we should take care about inner events and don't let them to affect other components

@reva2
Copy link

reva2 commented May 27, 2015

+1

brianfeister pushed a commit that referenced this pull request May 28, 2015
Stop propagation when pressing ENTER or ESC key from dropdown
@brianfeister brianfeister merged commit 5f91e77 into angular-ui:master May 28, 2015
@longzheng
Copy link

Thank you thank you thank you.

@user378230 user378230 mentioned this pull request Feb 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants