Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

fixed #808 #810

Merged
merged 3 commits into from
Feb 18, 2016
Merged

fixed #808 #810

merged 3 commits into from
Feb 18, 2016

Conversation

mareczek
Copy link
Contributor

No description provided.

@zbabtkis
Copy link

What's the status on this PR? Are there any workarounds in the meantime?

@aaronroberson aaronroberson merged commit 8c5d0b9 into angular-ui:master Feb 18, 2016
@user378230
Copy link
Contributor

FYI: There's now a duplication of the checks on KEY.ENTER and KEY.ESC merged as part of PR #901

  ctrl.searchInput.on('keydown', function(e) {
    ...
    if (~[KEY.ENTER,KEY.ESC].indexOf(key)){
      e.preventDefault();
      e.stopPropagation();
    }

    // if(~[KEY.ESC,KEY.TAB].indexOf(key)){
    ...
    ...
    ...
      _ensureHighlightVisible();
    }

    if (key === KEY.ENTER || key === KEY.ESC) {
      e.preventDefault();
      e.stopPropagation();
    }

  });

uiSelectController.js#L494

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants