fix(@angular/cli): capture CPU profile

Replace the v8-profiler dependency with v8-profiler-node8 as the first one doesn't support node 8 and 10, and that @angular/cli support only node 8 and 10.
angular · Oct 3, 2018 · 3de49db · 3de49db
1 parent eab4c2e
commit 3de49db
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/lib/bootstrap-local.js b/lib/bootstrap-local.js
@@ -26,10 +26,10 @@ if (process.env['CODE_COVERAGE'] || process.argv.indexOf('--code-coverage') !==
 let profiler = null;
 if (process.env['DEVKIT_PROFILING']) {
   try {
-    profiler = require('v8-profiler');
+    profiler = require('v8-profiler-node8');
   } catch (err) {
-    throw new Error(`Could not require 'v8-profiler'. You must install it separetely with` +
-      `'npm install v8-profiler --no-save.\n\nOriginal error:\n\n${err}`);
+    throw new Error(`Could not require 'v8-profiler-node8'. You must install it separetely with` +
+      `'npm install v8-profiler-node8 --no-save.\n\nOriginal error:\n\n${err}`);
   }
 
   profiler.startProfiling();

diff --git a/packages/angular/cli/lib/init.ts b/packages/angular/cli/lib/init.ts
@@ -43,8 +43,16 @@ function _fromPackageJson(cwd?: string) {
 
 // Check if we need to profile this CLI run.
 if (process.env['NG_CLI_PROFILING']) {
-  const profiler = require('v8-profiler'); // tslint:disable-line:no-implicit-dependencies
+  let profiler: any = null;
+  try {
+    profiler = require('v8-profiler-node8'); // tslint:disable-line:no-implicit-dependencies
+  } catch (err) {
+    throw new Error(`Could not require 'v8-profiler-node8'. You must install it separetely with` +
+      `'npm install v8-profiler-node8 --no-save.\n\nOriginal error:\n\n${err}`);
+  }
+
   profiler.startProfiling();
+
   const exitHandler = (options: { cleanup?: boolean, exit?: boolean }) => {
     if (options.cleanup) {
       const cpuProfile = profiler.stopProfiling();