Skip to content

Commit

Permalink
feat(@angular/cli): use tslint language service
Browse files Browse the repository at this point in the history
tslint-language-service can support tslint rules that require the type checker
share program representation with TypeScript (no need to reanalyze)

Fixes: #6125
  • Loading branch information
ValeryVS committed Jun 8, 2017
1 parent 01cbf65 commit b2e81a8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
5 changes: 3 additions & 2 deletions packages/@angular/cli/blueprints/ng/files/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,13 @@
"karma": "~1.7.0",
"karma-chrome-launcher": "~2.1.1",
"karma-cli": "~1.0.1",
"karma-coverage-istanbul-reporter": "^1.2.1",
"karma-jasmine": "~1.1.0",
"karma-jasmine-html-reporter": "^0.2.2",
"karma-coverage-istanbul-reporter": "^1.2.1",
"protractor": "~5.1.2",
"ts-node": "~3.0.4",
"tslint": "~5.3.2",<% } %>
"tslint": "~5.3.2",
"tslint-language-service": "^0.9.6",<% } %>
"typescript": "~2.3.3"
}
}
7 changes: 6 additions & 1 deletion packages/@angular/cli/blueprints/ng/files/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
"lib": [
"es2016",
"dom"
]
]<% if (!minimal) { %>,
"plugins": [
{
"name": "tslint-language-service"
}
]<% } %>
}
}
1 change: 1 addition & 0 deletions tests/e2e/tests/commands/new/new-minimal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export default function() {
.then(() => expectToFail(() => expectFileToMatch('package.json', '"protractor":')))
.then(() => expectToFail(() => expectFileToMatch('package.json', '"karma":')))
.then(() => expectToFail(() => expectFileToMatch('package.json', '"jasmine-core":')))
.then(() => expectToFail(() => expectFileToMatch('package.json', '"tslint-language-service":')))

// Try to run a build.
.then(() => ng('build'));
Expand Down

0 comments on commit b2e81a8

Please sign in to comment.