Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add tslint-language-service to dependencies #6125

Closed
angelozerr opened this issue Apr 29, 2017 · 7 comments · Fixed by #6144
Closed

Please add tslint-language-service to dependencies #6125

angelozerr opened this issue Apr 29, 2017 · 7 comments · Fixed by #6144
Labels
effort1: easy (hours) feature Issue that requests a new feature

Comments

@angelozerr
Copy link

angelozerr commented Apr 29, 2017

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

Repro steps.

The log given by the failure.

Desired functionality.

Mention any other details that might be useful.

Like #5497 please add TSLint Language Service plugin.

And give an option to declare it in the tsconfig.json like this:

{
  "compilerOptions": {
    "plugins": [
      { "name": "tslint-language-service"}
    ]
  }
}

This TypeScript plugin can be used with any IDE (VSCode, WebStorm, Eclipse, etc) to provide tslint diagnostic and codefix in your editor.

Thanks!

@sumitarora sumitarora self-assigned this May 1, 2017
@filipesilva filipesilva added effort1: easy (hours) feature Issue that requests a new feature labels May 5, 2017
@filipesilva
Copy link
Contributor

Oh sorry, this wasn't fixed by #6144.

@filipesilva
Copy link
Contributor

I'm marking this as a discussion though, adding it depends on up to date versions of a lot of things so it's not a cut and dry thing.

@ValeryVS
Copy link
Contributor

As far as I know, it depends on typescript@2.3. And @angular/cli@1.1.x also depends on this typescript version.

I installed package, add lines in tsconfig and disable tslint extension in my vscode.
All seems to be working properly.

@ValeryVS
Copy link
Contributor

ValeryVS commented May 30, 2017

With tslint-language-service it is possible to view errors for rules, that require type checking.
But not all...
For example, I can't see no-unused-variable errors in VSCode.

Rules, that require type checking, aren't work with current vscode-tslint plugin any way.

@angelozerr
Copy link
Author

angelozerr commented May 30, 2017

@ValeryVS the goal of this issue is to integrate tslint-language-service with angular-cli.

For example, I can't see no-unused-variable errors in VSCode.

Yes it's a known problem, you can read it at https://github.com/angelozerr/tslint-language-service (in Notice section)

If you have problems with tslint-language-service, please create issues at https://github.com/angelozerr/tslint-language-service/issues

ValeryVS added a commit to ValeryVS/angular-cli that referenced this issue May 30, 2017
tslint-language-service can support tslint rules that require the type checker
share program representation with TypeScript (no need to reanalyze)

Fixes: angular#6125
ValeryVS added a commit to ValeryVS/angular-cli that referenced this issue Jun 8, 2017
tslint-language-service can support tslint rules that require the type checker
share program representation with TypeScript (no need to reanalyze)

Fixes: angular#6125
ValeryVS added a commit to ValeryVS/angular-cli that referenced this issue Jul 26, 2017
tslint-language-service can support tslint rules that require the type checker
share program representation with TypeScript (no need to reanalyze)

Fixes: angular#6125
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@mgechev
Copy link
Member

mgechev commented Dec 18, 2018

For now tslint without the language service has been sufficient for the CLI. Let's close this feature request for now and revisit in future.

@mgechev mgechev closed this as completed Dec 18, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort1: easy (hours) feature Issue that requests a new feature
Projects
None yet
6 participants