Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate build optimizer getImportTslibTransformer #15401

Closed
alan-agius4 opened this issue Aug 21, 2019 · 1 comment
Closed

Deprecate build optimizer getImportTslibTransformer #15401

alan-agius4 opened this issue Aug 21, 2019 · 1 comment
Labels
feature Issue that requests a new feature
Milestone
v9-candidates

Comments

@alan-agius4
Copy link
Collaborator

🚀 Feature request

Description

We should deprecate build optimizer getImportTslibTransformer transformer and display a warning when ever a library needs this transformer. That way developers can file issue reports with the library authors.

Library authors should ship their code already optimized by enabling importHelpers in their tsconfig.

More info:
https://www.typescriptlang.org/docs/handbook/compiler-options.html https://github.com/Microsoft/tslib
@alan-agius4 alan-agius4 added feature Issue that requests a new feature comp: devkit/build-optimizer labels Aug 21, 2019
@alan-agius4 alan-agius4 added this to the 9.0.x milestone Aug 21, 2019
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 3, 2019
@filipesilva
feat(@angular-devkit/build-optimizer): don't use getImportTslibTransf…
81e659d 
…ormer

This transformer can cause size regressions when it introduces `tslib` imports across independent chunks.

It should be deprecated because tslib adoption has become more ubiquitous.

Should also speed up Build Optimizer processing time because there's one less thing to do.

Closes angular#15401 without adding the warning, because some libraries like zone.js should inline the helpers.
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 3, 2019
@filipesilva
feat(@angular-devkit/build-optimizer): don't use getImportTslibTransf…
7147412 
…ormer

This transformer can cause size regressions when it introduces `tslib` imports across independent chunks.

It should be deprecated because tslib adoption has become more ubiquitous.

Should also speed up Build Optimizer processing time because there's one less thing to do.

Closes angular#15401 without adding the warning, because some libraries like zone.js should inline the helpers.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature Issue that requests a new feature
Projects
None yet
Milestone
v9-candidates
Development

No branches or pull requests
1 participant
@alan-agius4