Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linefeed setting from editor config #2716

Closed
JasonGoemaat opened this issue Oct 15, 2016 · 2 comments · Fixed by #2829
Closed

Remove linefeed setting from editor config #2716

JasonGoemaat opened this issue Oct 15, 2016 · 2 comments · Fixed by #2829

Comments

@JasonGoemaat
Copy link

JasonGoemaat commented Oct 15, 2016

OS: Windows 10

Versions:
angular-cli: 1.0.0-beta.15
node: 6.6.0
os: win32 x64

No failure, but the editor config"end_of_line = lf" is annoying for windows if the user has setup git with "core.autocrlf = true", which most people should have done by now. I don't see why the angular-cli project should take a position on this preference, or really any of them. Editorconfig is handy, but including a default one in any cli project can cause grief. I prefer checking out crlf on windows and my editors handle that fine. Having this in editorconfig would work if I set a local repository config for autocrlf=false or input, but then if I happen to use an editor that ignores the editorconfig I would end up committing crlf. It caused some confusion with another team member because every time he did a checkout his editor would tell him all the files he had open have changed.

@filipesilva
Copy link
Contributor

Would you be interested in making a PR to fix this? I'll review it.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants