Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on @angular/animations for ng new projects #5928

Closed
StephenFluin opened this issue Apr 12, 2017 · 7 comments · Fixed by #6144
Closed

Add dependency on @angular/animations for ng new projects #5928

StephenFluin opened this issue Apr 12, 2017 · 7 comments · Fixed by #6144
Labels
effort1: easy (hours) feature Issue that requests a new feature P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity1: confusing

Comments

@StephenFluin
Copy link
Contributor

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [X] feature request

Versions.

@angular/cli: 1.0.0

Desired functionality.

The CLI should add @angular/animations by default to the package.json. This would make it easier to use animations and Angular Material, without any downside on rendered bundles unless the user imports them.

@sumitarora sumitarora self-assigned this Apr 12, 2017
@dave11mj
Copy link
Contributor

dave11mj commented Apr 12, 2017

Sounds related to #5785 .. There should be a PR open to add @angular/animations (#5786), although it adds it as an opt-in feature to allow the user to decide instead of adding additional node packages to a project that doesn't need them.

@filipesilva
Copy link
Contributor

@dave11mj we're looking at just adding the dependency with no generated files. This is part of some improvements we're making for the new projects.

@filipesilva filipesilva added effort1: easy (hours) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity1: confusing feature Issue that requests a new feature labels May 4, 2017
@dave11mj
Copy link
Contributor

dave11mj commented May 4, 2017

@filipesilva I opened a PR for the dependency on #5786 it seemed alright with @Brocco except for a change request to remove the generated file which I already applied on the commit. Could you take a look at it and let me know if its aligned with the requirements ? ^^

Thanks ! :D

@filipesilva
Copy link
Contributor

I'll ping @Brocco about it to see what should be done.

@filipesilva
Copy link
Contributor

Heya, turned out work as ongoing in #6144 now so I closed your PR in favor of that one. Thanks for taking the time to help out!

@dave11mj
Copy link
Contributor

dave11mj commented May 5, 2017

@filipesilva #6144 fixes this issue too literally only by adding @angular/animations to the package.json. If thats the only requirement to address this ticket, then could we reopen #5785, @Brocco seemed to like the idea, and it's significantly different given it asks not only for the @angular/animations package to be downloaded into the node_modules but also for animations to be supported out of the box by the cli, which involves a little more than just adding the package to the package.json .

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort1: easy (hours) feature Issue that requests a new feature P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity1: confusing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants