Fix virtual file invalidation #12591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
added
needs: discussion
This was referenced Oct 15, 2018
filipesilva
force-pushed
the
fix-invalidate-context
branch
from
e6601c1
to
7bd5d3a
Compare
filipesilva
added
state: blocked
target: patch
clydin
requested changes
Oct 15, 2018
| @@ -80,8 +87,13 @@ export class WebpackCompilerHost implements ts.CompilerHost { | |||
| invalidate(fileName: string): void { | |||
| const fullPath = this.resolve(fileName); | |||
|
|
|||
| if (this._memoryHost.exists(fullPath)) { | |||
| this._memoryHost.delete(fullPath); | |||
| if (fullPath.endsWith('.ts')) { | |||
There was a problem hiding this comment.
Need to also check if it no longer exists on disk as well.
There was a problem hiding this comment.
Ah yes, and I think that's what (rightfully) causing that failure on test-large.
filipesilva
force-pushed
the
fix-invalidate-context
branch
from
7bd5d3a
to
fbe4e30
Compare
clydin
requested changes
Oct 16, 2018
| this._sourceFileCache.delete(fullPath); | ||
|
|
||
| try { | ||
| const exists = this._syncHost.isFile(fullPath); | ||
| if (exists) { | ||
| this._changedFiles.add(fullPath); | ||
| } | ||
| } catch { } | ||
| } catch { |
There was a problem hiding this comment.
isFile may or may not throw if the file exists. Some host do and some do not.
Maybe something similar to the following:
let exists = false;
try {
exists = this._syncHost.isFile(fullPath);
if (exists) {
this._changedFiles.add(fullPath);
}
} catch { }
// File doesn't exist anymore, so we should delete the related virtual files.
if (!exists && fullPath.endsWith('.ts')) {
this._virtualFileExtensions.forEach(ext => {
const virtualFile = (fullPath.slice(0, -3) + ext) as Path;
if (this._memoryHost.exists(virtualFile)) {
this._memoryHost.delete(virtualFile);
}
});
}
fbe4e30
to
d1b1602
Compare
clydin
approved these changes
Oct 16, 2018
filipesilva
force-pushed
the
fix-invalidate-context
branch
from
d1b1602
to
afb5279
Compare
|
@filipesilva I think this also solves #12620? |
|
I'm not sure it's related. Have you tested it? |
|
@filipesilva I gave it a shot and cannot replicate. Will ask for repo. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #12588, should fix #12260 going forward.
Fix #9669
Fix #12657