Tests failing on 7.0.0-rc.3

[ronaldmansveld]

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [X] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Windows 10
NPM 6.2.0

Angular CLI: 7.0.0-rc.3
Node: 10.8.0
OS: win32 x64
Angular: 7.0.0-rc.1
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

Package Version

@angular-devkit/architect 0.9.0-rc.3
@angular-devkit/build-angular 0.9.0-rc.3
@angular-devkit/build-optimizer 0.9.0-rc.3
@angular-devkit/build-webpack 0.9.0-rc.3
@angular-devkit/core 7.0.0-rc.3
@angular-devkit/schematics 7.0.0-rc.3
@angular/cdk 7.0.0-rc.2
@angular/cli 7.0.0-rc.3
@angular/material 7.0.0-rc.2
@angular/material-moment-adapter 7.0.0-rc.2
@angular/pwa 0.8.5
@ngtools/webpack 7.0.0-rc.3
@schematics/angular 7.0.0-rc.3
@schematics/update 0.9.0-rc.3
rxjs 6.3.3
typescript 3.1.3
webpack 4.19.1

Repro steps

1. Create new project
2. Run test
3. Add service
4. Start added tests to spec file

The log given by the failure

ERROR in ./src/app/common-services/services/language/language.service.ts
Module build failed (from ./node_modules/@ngtools/webpack/src/index.js):
Error: C:\dev\dotnet\Recon\ResponsiveWeb\v3\src\app\common-services\services\language\language.service.ts is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property.
at AngularCompilerPlugin.getCompiledFile (C:\dev\dotnet\Recon\ResponsiveWeb\v3\node_modules@ngtools\webpack\src\packages\ngtools\webpack\src\angular_compiler_plugin.ts:1021:15)
at plugin.done.then (C:\dev\dotnet\Recon\ResponsiveWeb\v3\node_modules@ngtools\webpack\src\packages\ngtools\webpack\src\loader.ts:49:29)
at process._tickCallback (internal/process/next_tick.js:68:7)
@ ./src/app/common-services/services/language/language.service.spec.ts 1:0-53 5:22-37
@ ./src sync .spec.ts$
@ ./src/test.ts

Desired functionality

Test should not randomly fail after adding a test case

Mention any other details that might be useful

Using custom schematics that adds an extra directory level under a module

[ronaldmansveld]

Some extra information:

• I tried adding '**/*.ts' to the include array of tsconfig.spec.json, with no effect
• Sometimes it errors on the service not being part of the typescript compilation, sometimes it errors on the containing module not being part, and sometimes the services is shown as a warning (with the same message) and the module as an error. Haven't found a way to replicate either of those consistently
• Ctrl-C-ing the failing run, and restarting ng test sometimes runs the tests succesfully, sometimes it just hangs and runs no tests at all

[ronaldmansveld]

Managed to narrow the issue further down:

After some changes in my spec file (as that had errors that were not reported anywhere apart from the console in the browser running karma), the issue now only happens when changing and saving the service. Changing and saving the spec file re-runs the tests normally without issues.

Saving the service while ng test is still running makes ng test crash with the 'is missing from TypeScript compilation' error.

Both restarting ng test, as well as reloading the browser window running karma will execute the tests normally.

[alan-agius4]

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?

You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

This might be related to your directory structure so its really important to get an accurate repro to diagnose this.