New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/update): check if replace is a function #13389

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
5 participants
@joeson1
Copy link
Contributor

joeson1 commented Jan 9, 2019

When substituting environment variables in npmrc options, string replace was also applied on boolean values. This caused the ng update process to fail #10624

Show resolved Hide resolved packages/schematics/update/update/npm.ts Outdated
@clydin

clydin approved these changes Jan 9, 2019

Copy link
Member

clydin left a comment

Note to caretaker: please squash with the following commit message:
fix(@schematics/update): ensure option is string when replacing environment variable references

@alan-agius4
Copy link
Collaborator

alan-agius4 left a comment

Kindly squash your commits into a single one.

fix(@schematics/update): ensure option is string when replacing envir…
…onment variable references

When substituting environment variables in npmrc options, string replace was also applied on boolean values. This caused the ng update process to fail

@joeson1 joeson1 force-pushed the joeson1:patch-2 branch from c133d1e to aab40a0 Jan 10, 2019

@joeson1

This comment has been minimized.

Copy link
Contributor

joeson1 commented Jan 11, 2019

@alan-agius4 I squashed the commits

@joeson1 joeson1 closed this Jan 11, 2019

@joeson1 joeson1 reopened this Jan 11, 2019

@kyliau kyliau merged commit 08d067a into angular:master Jan 11, 2019

13 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-node-8 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment