fix(@angular-devkit/build-angular): add missing declaration types …

[gatthias]

…in build_angular schemas.

Fixes issue #13388

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[gatthias]

Hi,

I made this pull request to specifically address issue #13388.
I get that this issue has been closed by @hansl as "working as intended", but I kindly disagree with this as this breaks the ability to cleanly compile custom builders deriving or using the BrowserBuilder. I even wonder how transpilation worked on your side since 7.2.0 given these broken types declarations links.

This PR fixes this, and allow fellow devs to continue working with their own builders setup while waiting for v8.

To break circular dependencies, I had to move two declarations NormalizedSourceMaps and NormalizedOptimization away from utils. I chose to declare them in browser/schema as imports from this file were already present for every other files that needed these declarations. This is not ideal, but I thought that putting these right between NormalizedBrowserBuilderSchema and it's above TODO comment would be the best compromise. Please, do tell if you disagree.

Sincerely sorry for the little mess with commits:

• First one didn't have the right author information and did not pass linting
• Second one corrected lint issues, I marked it "refactor" rather than "style" as some code needed to be moved to avoid circular dependencies. Hope I did well there.
• Subsequent ones were needed to fix the first commit's authorship issue.

Finally, I'm not sure why two items of test-large failed on CI when it worked locally:

20 Browser Builder rebuilds

    √ rebuilds on TS file changes (10 secs)

    √ rebuilds on CSS changes (8 secs)

    √ type checks on rebuilds (12 secs)

    √ rebuilds on type changes (9 secs)

Thank you for your amazing work, I hope this edit can help.

[alan-agius4]

Thanks for this, kindly squash all commits.

The failing test seems to be a flake.

[googlebot]

CLAs look good, thanks!

[gatthias]

Well I just learned about squashing. I hope it's all good, Bot seems okay with this.
Thanks, learning everyday 👍 !

EDIT: I'll be damned, these actions broke linting again. Back to it...

[gatthias]

Okay seems all good to me. I believe the last merge status check is on your side.
I'll get back to use these changes now !

One last thing though, as this PR moves two declarations, do you think we should export back these two types from utils for backward compatibility ? Something like :

utils/index.ts
export { NormalizedOptimization, NormalizedSourceMaps } from '../browser/schema';

Kinda ugly but it might prevent further issues ?

EDIT: Just checked, it wouldn't break linting.

[alan-agius4]

Thanks LGTM

[alan-agius4]

@opulisDynamics I don't see the need for that.

[imzachwolf]

My build was fixed with "@angular-devkit/build-angular": "0.13.9". Thanks folks.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}