refactor(@angular-devkit/build-angular): remove file-loader dependency #19882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`file-loader` resolves `import/require()` on a file into a url. This is non standard, undocumented, unsupported Webpack specific functionality. This was introduced in the Angular CLI before `postcss-cli-resources` existed and was never removed. Using `file-loader` and `postcss-cli-resources` are no longer needed with Webpack 5, because of the introduction of [Assets Modules](https://webpack.js.org/guides/asset-modules/). BREAKING CHANGE: The unsupported/undocumented, Webpack specific functionality to `import`/`require()` a non-module file has been removed. Before ```js import img from './images/asset.png'; ``` After ```html <img src="images/asset.png"> ```
alan-agius4
added
state: blocked
needs: discussion
alan-agius4
removed
the
needs: discussion
clydin
approved these changes
Jan 28, 2021
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file-loaderresolvesimport/require()on a file into a url. This is non standard, undocumented, unsupported Webpack specific functionality. This was introduced in the Angular CLI beforepostcss-cli-resourcesexisted and was never removed.Using
file-loaderandpostcss-cli-resourcesare no longer needed with Webpack 5, because of the introduction of Assets Modules.BREAKING CHANGE:
The unsupported/undocumented, Webpack specific functionality to
import/require()a non-module file has been removed.Before
After