esbuild-based builder code cleanup/refactoring #25066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin diagnostic utilities The TypeScript diagnostic to esbuild diagnostic conversion utilities are now contained in a separate file. This lowers the line count of the main compiler plugin file and also removes an additional direct usage of the `typescript` dependency from the compiler plugin file.
…et files The stylesheet related files for the esbuild-based browser application builder have now been moved into a `stylesheets` directory to better organize the code.
…uild dev-server The change detection logic for the output files is now moved to a separate function to reduce the code line count for the main dev-server function. Also changed the setup function for the vite server to return the actual configuration to allow for better reuse and testability.
clydin
force-pushed
the
esbuild/misc-refactors
branch
from
552514e
to
41ce297
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Apr 26, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript diagnostic to esbuild diagnostic conversion utilities are now contained in a
separate file. This lowers the line count of the main compiler plugin file and also removes
an additional direct usage of the
typescriptdependency from the compiler plugin file.The stylesheet related files for the esbuild-based browser application builder
have now been moved into a
stylesheetsdirectory to better organize the code.