Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esbuild-based builder code cleanup/refactoring #25066

Merged
merged 3 commits into from
Apr 26, 2023
Merged

esbuild-based builder code cleanup/refactoring #25066

merged 3 commits into from
Apr 26, 2023

Commits on Apr 26, 2023

  1. refactor(@angular-devkit/build-angular): separate esbuild compiler pl… 

    …ugin diagnostic utilities

The TypeScript diagnostic to esbuild diagnostic conversion utilities are now contained in a
separate file. This lowers the line count of the main compiler plugin file and also removes
an additional direct usage of the `typescript` dependency from the compiler plugin file.
    @clydin
    clydin committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    37c645b View commit details
    Browse the repository at this point in the history

  2. refactor(@angular-devkit/build-angular): consolidate esbuild styleshe… 

    …et files

The stylesheet related files for the esbuild-based browser application builder
have now been moved into a `stylesheets` directory to better organize the code.
    @clydin
    clydin committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    8dfa48f View commit details
    Browse the repository at this point in the history

  3. refactor(@angular-devkit/build-angular): separate change logic in esb… 

    …uild dev-server

The change detection logic for the output files is now moved to a separate function
to reduce the code line count for the main dev-server function.
Also changed the setup function for the vite server to return the actual configuration
to allow for better reuse and testability.
    @clydin
    clydin committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    41ce297 View commit details
    Browse the repository at this point in the history