feat(generate): add option to auto-export declarations #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocco
force-pushed
the
gen-export-option
branch
from
8f28998
to
862f200
Compare
hansl
reviewed
Jan 10, 2017
| @@ -21,7 +21,8 @@ module.exports = { | |||
| { name: 'view-encapsulation', type: String, aliases: ['ve'] }, | |||
| { name: 'change-detection', type: String, aliases: ['cd'] }, | |||
| { name: 'skip-import', type: Boolean, default: false }, | |||
| { name: 'module', type: String, aliases: ['m'] } | |||
| { name: 'module', type: String, aliases: ['m'] }, | |||
| { name: 'exports', type: Boolean, default: false } | |||
There was a problem hiding this comment.
export instead of exports (drop the s).
hansl
suggested changes
Jan 10, 2017
| @@ -21,7 +21,8 @@ module.exports = { | |||
| { name: 'view-encapsulation', type: String, aliases: ['ve'] }, | |||
| { name: 'change-detection', type: String, aliases: ['cd'] }, | |||
| { name: 'skip-import', type: Boolean, default: false }, | |||
| { name: 'module', type: String, aliases: ['m'] } | |||
| { name: 'module', type: String, aliases: ['m'] }, | |||
| { name: 'exports', type: Boolean, default: false } | |||
Brocco
force-pushed
the
gen-export-option
branch
from
862f200
to
bf9be5e
Compare
|
LGTM. Thanks! |
hansl
approved these changes
Jan 13, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3778