-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(@angular-cli): get rid of ast-tools and base-href-webpack #4411
Conversation
Those 2 packages were still using the wrong scope (@angular-cli) and were not used by anyone outside the CLI. Just moving the code in the main package is enough.
26d4bdd
to
6f1b7b6
Compare
…ngular#4411) Those 2 packages were still using the wrong scope (@angular-cli) and were not used by anyone outside the CLI. Just moving the code in the main package is enough.
Hi @hansl I just upgraded to beta.31. Locally everything works fine but on CI
It seems to be related to this change. Just what is weird for me is that on my mac (sierra) it is working without any problem local versions:
on CI in docker container:
|
never mind ... as we had to extend build for production to change some paths, we copy webpack configuration and there was old path to the plugin |
…ngular#4411) Those 2 packages were still using the wrong scope (@angular-cli) and were not used by anyone outside the CLI. Just moving the code in the main package is enough.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Those 2 packages were still using the wrong scope (@angular-cli) and were not used by anyone outside the CLI. Just moving the code in the main package is enough.