Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-cli): get rid of ast-tools and base-href-webpack #4411

Merged
merged 1 commit into from
Feb 4, 2017

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Feb 3, 2017

Those 2 packages were still using the wrong scope (@angular-cli) and were not used by anyone outside the CLI. Just moving the code in the main package is enough.

Those 2 packages were still using the wrong scope (@angular-cli) and were not used by anyone outside the CLI. Just moving the code in the main package is enough.
@hansl hansl merged commit c889dd8 into angular:master Feb 4, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
…ngular#4411)

Those 2 packages were still using the wrong scope (@angular-cli) and were not used by anyone outside the CLI. Just moving the code in the main package is enough.
@rokerkony
Copy link

Hi @hansl I just upgraded to beta.31. Locally everything works fine but on CI npm install ends with:

module.js:471
    throw err;
    ^

Error: Cannot find module '@angular-cli/base-href-webpack'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/var/jenkins_home/workspace/ure_DEV-2138-upgrade-ng-cli-AI3AYAJIGG7X7LU7UBWCKLS3ZMA2HPJAF5D6O7DDGRP3SGLYVPEA/webpack.config.js:14:27)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at requireConfig (/var/jenkins_home/workspace/ure_DEV-2138-upgrade-ng-cli-AI3AYAJIGG7X7LU7UBWCKLS3ZMA2HPJAF5D6O7DDGRP3SGLYVPEA/node_modules/webpack/bin/convert-argv.js:96:18)
    at /var/jenkins_home/workspace/ure_DEV-2138-upgrade-ng-cli-AI3AYAJIGG7X7LU7UBWCKLS3ZMA2HPJAF5D6O7DDGRP3SGLYVPEA/node_modules/webpack/bin/convert-argv.js:109:17
    at Array.forEach (native)
    at module.exports (/var/jenkins_home/workspace/ure_DEV-2138-upgrade-ng-cli-AI3AYAJIGG7X7LU7UBWCKLS3ZMA2HPJAF5D6O7DDGRP3SGLYVPEA/node_modules/webpack/bin/convert-argv.js:107:15)
    at Object.<anonymous> (/var/jenkins_home/workspace/ure_DEV-2138-upgrade-ng-cli-AI3AYAJIGG7X7LU7UBWCKLS3ZMA2HPJAF5D6O7DDGRP3SGLYVPEA/node_modules/webpack/bin/webpack.js:153:40)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

It seems to be related to this change. Just what is weird for me is that on my mac (sierra) it is working without any problem

local versions:

node -v => v6.9.2
npm -v => 3.10.8

on CI in docker container:

npm ERR! node v6.9.1
npm ERR! npm  v3.10.8

@rokerkony
Copy link

never mind ... as we had to extend build for production to change some paths, we copy webpack configuration and there was old path to the plugin
const base_href_webpack = require('./node_modules/@angular/cli/lib/base-href-webpack/base-href-webpack-plugin'); fixed our problem

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
…ngular#4411)

Those 2 packages were still using the wrong scope (@angular-cli) and were not used by anyone outside the CLI. Just moving the code in the main package is enough.
@hansl hansl deleted the ast-tools-removal branch August 2, 2018 19:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants