feat(command): ng test command runs karma #86

Brocco · 2015-12-03T01:55:48Z

Overrode the ember-cli test command to initialize the karma server
Then start the karma server based upon the karma.conf.js config file

closes #70

cironunes · 2015-12-03T18:23:28Z

addon/ng2/commands/test.js

+    },
+
+    run: function(commandOptions, rawArgs) {
+      var promise = new Promise(function(){});


What about having this.server.start() inside this function?

var promise = new Promise(function() { return this.server.start(); });

Brocco · 2015-12-03T19:53:50Z

That works update coming soon.

Been doing a whole bunch of TypeScript recently, so it didn't occur to me that lexical scoping via fat arrow wasn't in play in your snippet, so it had to be tweaked to:

var server = this.server;

return new Promise(function(){
  return server.start();
});
// or
var self = this;
// or
return new Promise(function(){
  return this.server.start();
}.bind(this));

I've opted to go w/ .bind

IgorMinar · 2015-12-04T07:06:05Z

addon/ng2/commands/test.js

+
+    init: function(){
+      var cwd = process.cwd();
+      this.karma = this.karma || require(cwd + '/node_modules/karma/lib/index');


use require.resolve instead

@IgorMinar I'm not familiar w/ require.resolve are you suggesting that I use do this:

this.karma = this.karma || require(require.resolve(cwd + '/node_modules/karma/lib/index'));

no that's not right. the problem is that we can't be hardcoding paths because it will cause issues on windows.

why can't we just say require('karma')? wouldn't that resolve correctly?

cwd points to the application dir and this file should be executed from cwd + '/node_modules/angular-cli/addon/ng2/commands/test.jsno? If that's the case thenrequire('karma')` should just work...

IgorMinar · 2015-12-04T07:12:03Z

shouldn't we trigger ng build when running ng test?

otherwise this looks good, I think.

@cironunes can you take a look as well?

@cironunes, @Brocco can you open another issue to integrate the build pipeline with karma so that we automatically rebuild the project when src changes, which then updates dist. we should then tell karma to rerun the tests. angular/angular repo has this setup. the implementation is a bit messy but it's a good start.

cironunes · 2015-12-04T11:42:36Z

@Brocco, nice one. As Igor said, please just make sure to run ng build before starting karma.

@IgorMinar, created the issue #87

Brocco · 2015-12-05T06:52:04Z

ng test will now execute a build and kick off karma

IgorMinar · 2015-12-05T06:55:50Z

tests/acceptance/test.spec.js

+    return ng([
+      'test',
+      '--skip-npm',
+      '--skip-bower'


do we need these two skip flags? I think they are needed only for init and new

I went back and checked ember's implementation and couldn't find a test spec for the test command. I think it is because we would need to run an npm install... otherwise requiring karma will fail

but ng init is executed above with these flags. I don't thing we need the flags here. they don't do anything. try removing.

cironunes · 2015-12-07T13:34:31Z

Protractor integration is getting done: #94.

Will we integrate it on ng test in this PR or do you want me to create a separate issue so we can discuss?

We'll probably need some flags as Igor were saying ng test --all(default)/unit/e2e

IgorMinar · 2015-12-10T06:44:22Z

I suggest we commit this first and then add protractor in a follow up PR

wrt ng test running protractor tests - I dunno, historically we've always treated e2e tests differently because they are slow and people rarely run them locally (only if CI is broken). So I think that we should make it easy to run e2e tests locally, but don't run them by default.

I'm open to be convinced otherwise. But again, we can discuss that in a follow up PR

IgorMinar · 2015-12-10T06:45:42Z

@Brocco are you blocked on anything? If not, can you resolve the comments above please so that we can merge this in?

Brocco · 2015-12-10T16:04:28Z

@IgorMinar I'm still not sure how to go about testing the test command (npm test from the cli project)

I updated this branch/PR to exclude the running of the ng test acceptance tests (xdescribe) in case anyone else wants to take a look in the meantime.

I added the karma args and defaulted it to be a single-run to alleviate confusion "why's that still running"

Brocco · 2015-12-10T17:06:19Z

Updated the readme to update the documentation on how to execute tests

cironunes · 2016-01-22T20:10:17Z

@Brocco can you rebase this with the latest changes from master?

googlebot · 2016-01-24T02:17:20Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

jkuri · 2016-01-24T02:46:24Z

Signed.

On 24 Jan 2016, at 03:17, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the company's name.
—
Reply to this email directly or view it on GitHub #86 (comment).

Brocco · 2016-01-24T03:08:51Z

I signed it!
On Jan 23, 2016 9:17 PM, "googlebot" notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

If you signed the CLA as a corporation, please let us know the
company's name.

—
Reply to this email directly or view it on GitHub
#86 (comment).

cironunes · 2016-01-24T12:41:18Z

@Brocco have you updated the PR?

I'm still seeing:

This branch is out-of-date with the base branch
Merge the latest changes from master into this branch.

filipesilva · 2016-02-14T14:17:51Z

addon/ng2/blueprints/ng2/files/karma.conf.js

@@ -14,6 +15,8 @@ module.exports = function(config) {
      {pattern: 'node_modules/angular2/bundles/http.dev.js', included: true, watched: true},
      {pattern: 'node_modules/angular2/bundles/router.dev.js', included: true, watched: true},
      {pattern: 'node_modules/angular2/bundles/testing.dev.js', included: true, watched: true},
+      {pattern: 'node_modules/es6-shim/es6-shim.js', included: true, watched: true},


Shouldn't these be in the same order as https://github.com/angular/angular-cli/blob/master/lib/broccoli/angular2-app.js#L21-L30 ?

filipesilva · 2016-02-14T14:23:51Z

Other than the comments I added in, lgtm.

Overrode the ember-cli test command to initialize the karma server Then start the karma server based upon the karma.conf.js config file closes angular#70

angular-automatic-lock-bot · 2019-09-09T21:42:18Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

cironunes reviewed Dec 3, 2015
View reviewed changes

Brocco force-pushed the ng-test branch from ab24902 to f12424b Compare December 3, 2015 20:05

IgorMinar reviewed Dec 4, 2015
View reviewed changes

IgorMinar assigned cironunes Dec 4, 2015

Brocco force-pushed the ng-test branch from f12424b to 31bd12c Compare December 5, 2015 06:49

IgorMinar reviewed Dec 5, 2015
View reviewed changes

IgorMinar mentioned this pull request Dec 10, 2015

feat(test): protractor integration, e2e test sample #94

Merged

Brocco force-pushed the ng-test branch from 31bd12c to befe22d Compare December 10, 2015 16:04

Brocco force-pushed the ng-test branch from befe22d to 3d15e3f Compare December 10, 2015 17:05

Brocco force-pushed the ng-test branch from 3d15e3f to 614ad71 Compare January 24, 2016 02:17

Brocco force-pushed the ng-test branch from 614ad71 to cfb8668 Compare January 24, 2016 13:55

Brocco force-pushed the ng-test branch 6 times, most recently from 9cf843d to 871fcc5 Compare February 6, 2016 04:51

Brocco force-pushed the ng-test branch 7 times, most recently from 5443097 to 07ef9f2 Compare February 14, 2016 04:34

Brocco assigned hansl and unassigned cironunes Feb 14, 2016

filipesilva reviewed Feb 14, 2016
View reviewed changes

Brocco force-pushed the ng-test branch from 07ef9f2 to 665fbd0 Compare February 14, 2016 14:44

feat(command): ng test command runs karma

6db91e7

Overrode the ember-cli test command to initialize the karma server Then start the karma server based upon the karma.conf.js config file closes angular#70

Brocco force-pushed the ng-test branch from 665fbd0 to 6db91e7 Compare February 14, 2016 15:50

filipesilva merged commit 6db91e7 into angular:master Feb 14, 2016

filipesilva mentioned this pull request Feb 14, 2016

Integrate the build pipeline with Karma #87

Closed

Brocco deleted the ng-test branch February 18, 2016 01:11

angular-automatic-lock-bot bot unassigned hansl Sep 9, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(command): ng test command runs karma #86

feat(command): ng test command runs karma #86

Brocco commented Dec 3, 2015

cironunes Dec 3, 2015

Brocco commented Dec 3, 2015

IgorMinar Dec 4, 2015

Brocco Dec 4, 2015

IgorMinar Dec 4, 2015

IgorMinar commented Dec 4, 2015

cironunes commented Dec 4, 2015

Brocco commented Dec 5, 2015

IgorMinar Dec 5, 2015

Brocco Dec 5, 2015

IgorMinar Dec 5, 2015

cironunes commented Dec 7, 2015

IgorMinar commented Dec 10, 2015

IgorMinar commented Dec 10, 2015

Brocco commented Dec 10, 2015

Brocco commented Dec 10, 2015

cironunes commented Jan 22, 2016

googlebot commented Jan 24, 2016

jkuri commented Jan 24, 2016

Brocco commented Jan 24, 2016

verify. Thanks.

cironunes commented Jan 24, 2016

filipesilva Feb 14, 2016

filipesilva commented Feb 14, 2016

angular-automatic-lock-bot bot commented Sep 9, 2019

feat(command): ng test command runs karma #86

feat(command): ng test command runs karma #86

Conversation

Brocco commented Dec 3, 2015

Choose a reason for hiding this comment

Brocco commented Dec 3, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IgorMinar commented Dec 4, 2015

cironunes commented Dec 4, 2015

Brocco commented Dec 5, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cironunes commented Dec 7, 2015

IgorMinar commented Dec 10, 2015

IgorMinar commented Dec 10, 2015

Brocco commented Dec 10, 2015

Brocco commented Dec 10, 2015

cironunes commented Jan 22, 2016

googlebot commented Jan 24, 2016

jkuri commented Jan 24, 2016

Brocco commented Jan 24, 2016

verify. Thanks.

cironunes commented Jan 24, 2016

Choose a reason for hiding this comment

filipesilva commented Feb 14, 2016

angular-automatic-lock-bot bot commented Sep 9, 2019