feat(test): protractor integration, e2e test sample #94

filipesilva · 2015-12-06T21:54:25Z

cironunes · 2015-12-07T13:29:03Z

README.md

 [ng test](https://github.com/angular/angular-cli/issues/70) is implemented.

+To run the end-to-end protractor tests, just do `$(npm bin)/protractor`.


Please add a note saying that you need to have the server running (ng serve) to execute protractor tests?

Roger, it is done.

cironunes · 2015-12-07T13:35:19Z

Thanks for the PR @filipesilva. I added a few comments, can you check?

filipesilva · 2015-12-07T14:46:20Z

Let me know what you'd like to do about webdriver and I'll add that in.

In the meanwhile, do you have something else specific for me to do? Or should I just go over help-wanted issues?

cironunes · 2015-12-07T14:58:57Z

@filipesilva you can take any issue that you feel like taking. The focus now is to build a cross-platform e2e testing suite for the project, but any help would be appreciated.

filipesilva · 2015-12-07T19:16:31Z

I moved the webdriver-manager update command to the readme. Anything else you think should be changed?

cironunes · 2015-12-08T11:00:08Z

@filipesilva let's just figure out how we'll integrate this with ng test so we can get this merged.

filipesilva · 2015-12-08T14:45:09Z

Hm... although ng test should be the umbrella command, unit tests and e2e have different use cases.

One would either run the unit tests once just to check everything is fine, or leave them running continuously while coding. In contrast, e2e tests are (in my experience) only ran once to check everything is fine.

Thus it might make sense to run e2e tests while running unit tests in single run, but it does not make sense to run e2e when unit tests are not in single run.

So to start off, I'd suggest that e2e tests are only ran explicitly, via ng test --e2e or something similar.

IgorMinar · 2015-12-10T06:57:42Z

@filipesilva right on - see my comment: #86 (comment)

IgorMinar · 2015-12-10T06:59:26Z

addon/ng2/blueprints/ng2/files/src/app/__name__.e2e.ts

@@ -0,0 +1,9 @@
+describe('<%= jsComponentName %> App', function() {
+
+  // #docregion redirect


docregion? :)

Ah, a remnant of the devguide example, my bad :p

IgorMinar · 2015-12-10T07:04:04Z

I'm not crazy about the manual steps we require, but we can fix that in follow up PRs.

How about renaming e2e extension to e2eSpec? Or is e2e clear enough? Maybe it is..

@juliemr do you have anything else you'd like to see in CLI when scaffolding the project/components?

filipesilva · 2015-12-10T23:04:01Z

I'm partial to just e2e. I feel it's clear enough and doesn't lead users towards camelCase for their file names, eg my-component.e2e.ts vs my-component.e2eSpec.ts, and variations my_component, myComponent.

cironunes · 2015-12-15T14:40:17Z

@filipesilva can you rebase the PR so we can get this merged?

filipesilva · 2015-12-15T14:44:52Z

Apologies @cironunes, I had to return to docs for the last week.

This isn't ready to be merged yet though. While looking at the matchers that Igor was recommending, I found out since the *.e2e.ts files were being compiled to SystemJS module loading, that was causing all sorts of trouble when trying to use modules in general for protractor.

I will need to separate the e2e tests onto another folder, and provide it with tsconfig.json that uses CommonJS module loading.

filipesilva · 2015-12-19T16:58:27Z

I've updated the commit to reflect the major changes, so please review again.

Highlights:

added e2e folder besides src with own tsconfig.json
fixed imports
added page object

cironunes · 2016-01-22T20:02:56Z

@filipesilva can you rebase this with the latest changes from master?

filipesilva · 2016-01-22T20:32:09Z

Rebased and confirmed it was still working.

cironunes · 2016-01-31T12:51:46Z

lgtm

angular-automatic-lock-bot · 2019-09-10T00:41:43Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

cironunes self-assigned this Dec 7, 2015

cironunes reviewed Dec 7, 2015
View reviewed changes

cironunes mentioned this pull request Dec 7, 2015

feat(command): ng test command runs karma #86

Merged

filipesilva force-pushed the protractor-integration branch 2 times, most recently from 80f5c5c to d2b33e3 Compare December 7, 2015 14:36

filipesilva force-pushed the protractor-integration branch 2 times, most recently from 5b4397f to df3e7c4 Compare December 7, 2015 19:14

IgorMinar reviewed Dec 10, 2015
View reviewed changes

filipesilva force-pushed the protractor-integration branch from df3e7c4 to 757c75e Compare December 10, 2015 22:55

filipesilva force-pushed the protractor-integration branch 2 times, most recently from dd508ad to 9deb8b3 Compare December 19, 2015 16:54

filipesilva force-pushed the protractor-integration branch from 9deb8b3 to 8510c8e Compare December 19, 2015 17:01

filipesilva force-pushed the protractor-integration branch from 8510c8e to fb89332 Compare January 22, 2016 20:22

filipesilva force-pushed the protractor-integration branch from fb89332 to 9343669 Compare January 23, 2016 10:43

filipesilva force-pushed the protractor-integration branch from 9343669 to b6baf78 Compare January 24, 2016 21:59

feat(test): protractor integration, e2e test sample

a0c26a3

filipesilva force-pushed the protractor-integration branch from b6baf78 to a0c26a3 Compare January 31, 2016 12:48

filipesilva merged commit a0c26a3 into angular:master Jan 31, 2016

filipesilva deleted the protractor-integration branch June 13, 2016 16:12

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(test): protractor integration, e2e test sample #94

feat(test): protractor integration, e2e test sample #94

filipesilva commented Dec 6, 2015

cironunes Dec 7, 2015

filipesilva Dec 7, 2015

cironunes commented Dec 7, 2015

filipesilva commented Dec 7, 2015

cironunes commented Dec 7, 2015

filipesilva commented Dec 7, 2015

cironunes commented Dec 8, 2015

filipesilva commented Dec 8, 2015

IgorMinar commented Dec 10, 2015

IgorMinar Dec 10, 2015

filipesilva Dec 10, 2015

IgorMinar commented Dec 10, 2015

filipesilva commented Dec 10, 2015

cironunes commented Dec 15, 2015

filipesilva commented Dec 15, 2015

filipesilva commented Dec 19, 2015

cironunes commented Jan 22, 2016

filipesilva commented Jan 22, 2016

cironunes commented Jan 31, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019

		[ng test](https://github.com/angular/angular-cli/issues/70) is implemented.

		To run the end-to-end protractor tests, just do `$(npm bin)/protractor`.

		@@ -0,0 +1,9 @@
		describe('<%= jsComponentName %> App', function() {

		// #docregion redirect

feat(test): protractor integration, e2e test sample #94

feat(test): protractor integration, e2e test sample #94

Conversation

filipesilva commented Dec 6, 2015

cironunes Dec 7, 2015

Choose a reason for hiding this comment

filipesilva Dec 7, 2015

Choose a reason for hiding this comment

cironunes commented Dec 7, 2015

filipesilva commented Dec 7, 2015

cironunes commented Dec 7, 2015

filipesilva commented Dec 7, 2015

cironunes commented Dec 8, 2015

filipesilva commented Dec 8, 2015

IgorMinar commented Dec 10, 2015

IgorMinar Dec 10, 2015

Choose a reason for hiding this comment

filipesilva Dec 10, 2015

Choose a reason for hiding this comment

IgorMinar commented Dec 10, 2015

filipesilva commented Dec 10, 2015

cironunes commented Dec 15, 2015

filipesilva commented Dec 15, 2015

filipesilva commented Dec 19, 2015

cironunes commented Jan 22, 2016

filipesilva commented Jan 22, 2016

cironunes commented Jan 31, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019