This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.5k
feat(ngAria): add support for ignoring a specific element #14833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @marcysutton Notes:
|
I like this idea; it would also help to address the config being global in #11174. It makes sense that disabling would only work for that specific node...crawling DOM subtrees would be too expensive. I like the future enhancement of disabling certain features, that was my one question after reviewing the PR. |
Narretz
approved these changes
Jun 6, 2018
LGTM, but must be rebased (and possibly updated if something has been added to ngAria) |
gkalpak
force-pushed
the
feat-ngAria-support-opting-out
branch
from
June 7, 2018 13:59
3c67f1d
to
4a7a438
Compare
Rebased. (AFAICT, nothing has been added to |
Just in case anyone (like me) is looking for when this feature was released, it was first available in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
It is not possible to force
ngAria
to "ignore" a specific element, i.e. not addaria-*
attributes, attachroles
, bind keyboard events etc. The only work-around is to provide those attributes yourself (in which casengAria
won't overwrite them), but this is tedious and doesn't work for all usecases.What is the new behavior (if this is a feature change)?
It is possible to force
ngAria
to "ignore" a specific element, by adding theng-aria-disable
attribute.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
Fixes #14602
Fixes #14672