Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Angular doesnt add ng-leave on nested routes #7515

Closed
dinodsaurus opened this issue May 19, 2014 · 7 comments
Closed

Angular doesnt add ng-leave on nested routes #7515

dinodsaurus opened this issue May 19, 2014 · 7 comments

Comments

@dinodsaurus
Copy link

Im using angular 1.3 and im using ng animate to animate view change. If i switch from /route1 to /route2 animation works just fine it animates ng-enter and ng-leave. But if I switch from /route1 to /route1/1 it add class ng-enter but it doesnt add ng-leave.
You can see this problem on the following link : http://mop-fest.com/#/gosti and then when you click on an image in the list on the right. @matsko

@matsko matsko self-assigned this May 19, 2014
@matsko
Copy link
Contributor

matsko commented May 19, 2014

It almost looks as if the animation is not getting called at all for leave on that particular route, but other routes are fine. The CSS code that you have for it looks fine as well:

div[ng-view].ng-leave {
  -webkit-animation: slideOutLeft 0.7s both cubic-bezier(0.61, 0.12, 0.395, 0.9);
  -moz-animation: slideOutLeft 0.7s both cubic-bezier(0.61, 0.12, 0.395, 0.9);
  animation: slideOutLeft 0.7s both cubic-bezier(0.61, 0.12, 0.395, 0.9);
}

I will continue to experiment with it. This is definitely a strange bug.

@matsko
Copy link
Contributor

matsko commented May 19, 2014

Could you possibly upload a non-minified version of this website or page somewhere so I can debug it without having to build something locally?

@dinodsaurus
Copy link
Author

you can find it here https://github.com/dinodsaurus/mop/tree/master/app/predavaci (I know... it is on croatian... my bad) if a live uncompressed version would help I will upload it. The code is pretty straight forward... predavaci.html is for the list view and gost.html is for the single view.In factory I have hardcoded all the presenters and in controller you have controllers for both views.

@lefos987 lefos987 added this to the 1.3.0 milestone May 20, 2014
@matsko
Copy link
Contributor

matsko commented Jun 3, 2014

OK I've figured it out. It is this bug caused by this issue: #6974

@matsko
Copy link
Contributor

matsko commented Jun 3, 2014

Once I get that fixed then we're good to go.

@dinodsaurus
Copy link
Author

cool! tnx

@btford btford removed the gh: issue label Aug 20, 2014
@jeffbcross jeffbcross modified the milestones: 1.3.0-rc.5, 1.3.0 Sep 29, 2014
@IgorMinar
Copy link
Contributor

I'm going to close this as dupe of #6974

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants