feat($parseProvider): add the additionalIsIdent configuration method

[gurdiga]

Allows extending of the set of character allowed in identifiers used in Angular expressions.

Closes #2174 #3847

[gurdiga]

Hey guys, what do you think about this approach?

@petebacondarwin @clee704 @lhaussknecht @dipold @dmethvin

[gurdiga]

Guys, what do you think about this thread here: https://groups.google.com/forum/#!topic/angular/-BUeo-5loOQ ?

[nissoh]

in my case. it seemed to have covered all hebrew letters but it fails on hebrew letters followed by space.
מחיר לפי פקטור

[gurdiga]

Hi Nissan!

Could you please fork me and write a failing test that would illustrate you
context? I guess this would help understand the issue.

Thank you!

On Fri, Dec 20, 2013 at 9:18 PM, Nissan Hanina notifications@github.comwrote:

in my case. it seemed to have covered all hebrew letters but it fails on
hebrew letters followed by space.
מחיר לפי פקטור

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4747#issuecomment-31034308
.

[clee704]

The code looks good. But the name additionalIsIdent sounds a little awkward (I'm not a native English speaker, so take it with a grain of salt). Have you considered other names?

[gurdiga]

@clee704 Yeah, I agree that the name is awkward, I just picked it just because it made sense to me after digging into Angular’s internals. I will think about a name that will make sense from an API user’s perspective, and, BTW, I’m open to ideas too! ;)

[gurdiga]

@clee704 I think I might have found a good name. :)

[mercibe]

Really need this feature. Non ASCII characters allowed in identifiers sounds like a problem solved 2 decades ago ;-) Will it be merged soon? Thank you!

[Macadoshis]

Most needed feature. Please someone merge it, dammit !

[petebacondarwin]

See #5881