Skip to content

Commit

Permalink
fix(karma): fix running karma via gulp
Browse files Browse the repository at this point in the history
As described below, the karma server showdown process can crash, if the done() function, provided
by gulp is referenced directly instead of wrapped in a closure function
http://stackoverflow.com/questions/26614738/issue-running-karma-task-from-gulp

Reformat the gulpfile.js

Squashing the two commits
  • Loading branch information
Alexander Bachmann authored and alexeagle committed Feb 2, 2016
1 parent 3e9b532 commit 27daeaf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ gulp.task('test.unit.js/ci', function(done) {
reporters: ['dots'],
browsers: browserConf.browsersToRun
},
done)
function(err) { done(); })
.start();
});

Expand Down

2 comments on commit 27daeaf

@pkozlowski-opensource
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle I don't think that this change is correct, IMO it should be reverted, see: karma-runner/gulp-karma#18 (comment)

@alexeagle
Copy link
Contributor

@alexeagle alexeagle commented on 27daeaf Feb 24, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.