-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ivy): capture template source mapping details during preanalysis (#…
…32544) Prior to this change, the template source mapping details were always built during the analysis phase, under the assumption that pre-analysed templates would always correspond with external templates. This has turned out to be a false assumption, as inline templates are also pre-analyzed to be able to preload any stylesheets included in the template. This commit fixes the bug by capturing the template source mapping details at the moment the template is parsed, which is either during the preanalysis phase when preloading is available, or during the analysis phase when preloading is not supported. Tests have been added to exercise the template error mapping in asynchronous compilations where preloading is enabled, similar to how the CLI performs compilations. Fixes #32538 PR Close #32544
- Loading branch information
Showing
5 changed files
with
141 additions
and
112 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters