Skip to content

Commit

Permalink
docs: remove unused CSS rules (#40069)
Browse files Browse the repository at this point in the history 
Removed rules don't affect their component views.
The reason - the templates don't contain elements to which that rules are applied.
See https://angular.io/guide/view-encapsulation for more details

PR Close #40069
  • Loading branch information
@AlexElin @alxhub
AlexElin authored and alxhub committed Dec 10, 2020
1 parent 91fb830 commit b08fd0c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 68 deletions.
20 changes: 3 additions & 17 deletions aio/content/examples/toh-pt4/src/app/messages/messages.component.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,12 @@ h2 {
font-family: Arial, Helvetica, sans-serif;
font-weight: lighter;
}
body {
margin: 2em;
}
body, input[text], button {
color: crimson;
font-family: Cambria, Georgia;
}

button.clear {
font-family: Arial;
font-family: Arial, sans-serif;
color: #333;
background-color: #eee;
margin-bottom: 12px;
border: none;
padding: 5px 10px;
border-radius: 4px;
Expand All @@ -23,12 +18,3 @@ button.clear {
button:hover {
background-color: #cfd8dc;
}
button:disabled {
background-color: #eee;
color: #aaa;
cursor: auto;
}
button.clear {
color: #333;
margin-bottom: 12px;
}
20 changes: 3 additions & 17 deletions aio/content/examples/toh-pt5/src/app/messages/messages.component.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,12 @@ h2 {
font-family: Arial, Helvetica, sans-serif;
font-weight: lighter;
}
body {
margin: 2em;
}
body, input[text], button {
color: crimson;
font-family: Cambria, Georgia;
}

button.clear {
font-family: Arial;
font-family: Arial, sans-serif;
color: #333;
background-color: #eee;
margin-bottom: 12px;
border: none;
padding: 5px 10px;
border-radius: 4px;
Expand All @@ -23,12 +18,3 @@ button.clear {
button:hover {
background-color: #cfd8dc;
}
button:disabled {
background-color: #eee;
color: #aaa;
cursor: auto;
}
button.clear {
color: #333;
margin-bottom: 12px;
}
20 changes: 3 additions & 17 deletions aio/content/examples/toh-pt6/src/app/messages/messages.component.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,12 @@ h2 {
font-family: Arial, Helvetica, sans-serif;
font-weight: lighter;
}
body {
margin: 2em;
}
body, input[text], button {
color: crimson;
font-family: Cambria, Georgia;
}

button.clear {
font-family: Arial;
font-family: Arial, sans-serif;
color: #333;
background-color: #eee;
margin-bottom: 12px;
border: none;
padding: 5px 10px;
border-radius: 4px;
Expand All @@ -23,12 +18,3 @@ button.clear {
button:hover {
background-color: #cfd8dc;
}
button:disabled {
background-color: #eee;
color: #aaa;
cursor: auto;
}
button.clear {
color: #333;
margin-bottom: 12px;
}
20 changes: 3 additions & 17 deletions aio/content/examples/universal/src/app/messages/messages.component.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,12 @@ h2 {
font-family: Arial, Helvetica, sans-serif;
font-weight: lighter;
}
body {
margin: 2em;
}
body, input[text], button {
color: crimson;
font-family: Cambria, Georgia;
}

button.clear {
font-family: Arial;
font-family: Arial, sans-serif;
color: #333;
background-color: #eee;
margin-bottom: 12px;
border: none;
padding: 5px 10px;
border-radius: 4px;
Expand All @@ -23,12 +18,3 @@ button.clear {
button:hover {
background-color: #cfd8dc;
}
button:disabled {
background-color: #eee;
color: #aaa;
cursor: auto;
}
button.clear {
color: #333;
margin-bottom: 12px;
}

1 comment on commit b08fd0c

@eneajaho
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I was playing around with the tour of heroes tutorial example and I was thinking about making a design rewrite so the newcomers also like what they will be developing.
And I started with the messages component.
Here is the stackblitz app.

How about I make a complete design rewrite and make a pull request for it?
Does it affect tests?

Please sign in to comment.