Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unused CSS rules #40069

Closed
wants to merge 1 commit into from

Conversation

AlexElin
Copy link
Contributor

Removed rules don't affect their component views because the templates don't contain elements to which that rules are applied.
See https://angular.io/guide/view-encapsulation for more details

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Removed rules don't affect their component views.
The reason - the templates don't contain elements to which that rules are applied.
See https://angular.io/guide/view-encapsulation for more details
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thx, @AlexElin 👍

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-docs-approvers

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker comp: docs refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release labels Dec 10, 2020
@ngbot ngbot bot modified the milestone: Backlog Dec 10, 2020
@pullapprove pullapprove bot removed the comp: docs label Dec 10, 2020
@ngbot ngbot bot removed this from the Backlog milestone Dec 10, 2020
alxhub pushed a commit that referenced this pull request Dec 10, 2020
Removed rules don't affect their component views.
The reason - the templates don't contain elements to which that rules are applied.
See https://angular.io/guide/view-encapsulation for more details

PR Close #40069
@alxhub alxhub closed this in b08fd0c Dec 10, 2020
@AlexElin AlexElin deleted the remove_unused_css_rules branch December 11, 2020 09:31
zarend pushed a commit to zarend/angular that referenced this pull request Dec 11, 2020
Removed rules don't affect their component views.
The reason - the templates don't contain elements to which that rules are applied.
See https://angular.io/guide/view-encapsulation for more details

PR Close angular#40069
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants