Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): enableLegacyTemplate should not be ignored #17051

Merged
merged 1 commit into from
May 30, 2017

Conversation

hotforfeature
Copy link
Contributor

Fixes #15555

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#15555

What is the new behavior?
Setting enableLegacyTemplate: false will no longer cause <template>s to be consumed by the compiler.

The option works correctly, there was just a missing line when merging options from the bootstrap that caused enableLegacyTemplate to always remain at the default true value.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@vicb vicb added area: core Issues related to the framework runtime action: review The PR is still awaiting reviews from at least one requested reviewer labels May 30, 2017
@vicb
Copy link
Contributor

vicb commented May 30, 2017

Thanks for the PR

@vicb vicb removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 30, 2017
@vicb vicb merged commit 8ffa483 into angular:master May 30, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enableLegacyTemplate option ignored
3 participants