fix(router): linking to redirects

[btford]

I pulled out the logic for finding a maximal element in a list into a facade, and parameterized it so you can provide your own mapping from element to value.

I've described pitfalls of this approach here: #3335 (comment)

Nevertheless, I think this is the best solution for now. I think we'll have to revisit redirects again to cover more general cases.

[matsko]

LGTM.

[matsko]

Did we talk about what we do if a redirect results in another redirect? Or does this code recurse over itself if the follow-up instruction is a redirect?

[btford]

Redirects should be final, not transitive. I don't want to allow cascading redirects within components like this:

/foo -> /bar
/bar -> baz

But I think a case where each child in a chain expands the URL or does redirects would be fine. I'll add another test case for that scenario.

[btford]

This should be good now, assuming CI goes green.

@matsko – I added another test for multiple redirects, and pulled some code out into a private method: https://github.com/angular/angular/pull/3624/files#diff-56a3f902acf026b93362cffea30dcf53R63

Can you take a look again?

[btford]

sent to presubmit 😄

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}