fix(forms): correct usage of selectedOptions
#37620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfaproject
reviewed
Jun 17, 2020
packages/forms/src/directives/select_multiple_control_value_accessor.ts
Outdated
Show resolved
Hide resolved
AndrewKushnir
added
area: forms
action: review
AndrewKushnir
added
the
target: patch
sonukapoor
force-pushed
the
select-multiple-ie-control-value-accessor
branch
2 times, most recently
from
b101d36
to
b43c7ba
Compare
Previously, `registerOnChange` used `hasOwnProperty` to identify if the property is supported. However, this does not work as the `selectedOptions` property is an inherited property. This commit fixes this by verifying the property on the prototype instead. Closes angular#37433
sonukapoor
force-pushed
the
select-multiple-ie-control-value-accessor
branch
from
b43c7ba
to
879d676
Compare
AndrewKushnir
added
action: presubmit
AndrewKushnir
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
LGTM, thanks for fixing this @sonukapoor 👍
Also huge thanks to @alfaproject and @CaerusKaru for providing very useful feedback!
|
FYI, presubmit went well, marking this PR as ready for merge. Thank you. |
AndrewKushnir
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
Previously, `registerOnChange` used `hasOwnProperty` to identify if the property is supported. However, this does not work as the `selectedOptions` property is an inherited property. This commit fixes this by verifying the property on the prototype instead. Closes angular#37433 PR Close angular#37620
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
registerOnChangeusedhasOwnPropertyto identify if theproperty is supported. However, this does not work as the
selectedOptionsproperty is an inherited property. This commit fixes this by verifying
the property on the prototype instead.
Closes #37433
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #37433
What is the new behavior?
Does this PR introduce a breaking change?
Other information