Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zone.js Mocha patch regression in v0.11.5 #46297

Closed
Alorel opened this issue Jun 8, 2022 · 5 comments
Closed

zone.js Mocha patch regression in v0.11.5 #46297

Alorel opened this issue Jun 8, 2022 · 5 comments
Assignees
Labels
area: zones P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Milestone

Comments

@Alorel
Copy link

Alorel commented Jun 8, 2022

Which @angular/* package(s) are the source of the bug?

Don't known / other

Is this a regression?

Yes

Description

The patch for it.skip disappeared in v0.11.5.

zone.js v0.11.4, fesm2015/zone-testing.js, line 1061:

    global.xit = global.xspecify = Mocha.it.skip = function () {
        return mochaOriginal.it.skip.apply(this, wrapTestInZone(arguments));
    };

zone.js v0.11.5, line 1061:

    global.xit = global.xspecify = function () {
        return mochaOriginal.it.skip.apply(this, wrapTestInZone(arguments));
    };

The function is still part of the Mocha API and shouldn't have been removed.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

it.skip is not a function

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 14.0.0
Node: 16.13.2
Package Manager: npm 8.3.2 
OS: linux x64

Angular: 14.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1400.0
@angular-devkit/build-angular   14.0.0
@angular-devkit/core            14.0.0
@angular-devkit/schematics      14.0.0
@schematics/angular             14.0.0
rxjs                            7.5.5
typescript                      4.7.3

Anything else?

No response

@ngbot ngbot bot added this to the needsTriage milestone Jun 8, 2022
@JiaLiPassion JiaLiPassion self-assigned this Jun 11, 2022
@JiaLiPassion
Copy link
Contributor

I will check it, thank you for posting the issue.

@luislobo
Copy link

I'm having the same issue

@alxhub alxhub added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 16, 2022
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 16, 2022
@JiaLiPassion
Copy link
Contributor

Sorry this is a regression, I have created a PR to fix it.

@JiaLiPassion
Copy link
Contributor

The PR is merged, I will close this one.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: zones P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants