feat(typescript): update to 1.9 nightly. #8003
Conversation
alexeagle
added
the
action: review
|
note, requires #8002 |
| compiledTree = replace(compiledTree, { | ||
| files: ['**/*.d.ts'], | ||
| patterns: [ | ||
| {match: /^(\s*)readonly\s+/mg, replacement: "$1"}, |
There was a problem hiding this comment.
What is this supposed to match?
There was a problem hiding this comment.
matches
readonly foo: any;
replace with
foo: any;
are you asking for a comment here to explain?
There was a problem hiding this comment.
Yeah, I didn't understand the purpose. A code comment with a link would be helpful so we can confidently remove this someday when 1.8 is no longer supported.
There was a problem hiding this comment.
added
// TODO(alexeagle): this can be removed once we drop support for using Angular 2 with TS 1.8
Would it be significant work (or an otherwise bad idea) to add a simple Travis job that installs TS 1.8 and runs |
|
Added a line in I don't want to add another matrix entry if possible, since that makes each build consume more travis workers. Since we already have this special typescript_next worker, it now has essentially this logic:
the |
chuckjaz
added
pr_state: LGTM
and removed
action: review
To workaround microsoft/TypeScript#7573 we must remove the readonly keyword from generated .d.ts files. This solution will not scale, but will probably buy enough time to require our users move to a 2.0 beta.
|
Merging PR #8003 on behalf of @alxhub to branch presubmit-alxhub-pr-8003. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Tested by build.js.cjs, copy to another folder, and manually run compiler to cause 1.8 to type-check the .d.ts files.
It would be better to have a test that runs ts1.8 typechecker in travis, but it's a real pain to change versions of a dependency partway through a build.