Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brocolli-typescript does not work with TS 1.9 #7050

Closed
alexeagle opened this issue Feb 13, 2016 · 9 comments
Closed

brocolli-typescript does not work with TS 1.9 #7050

alexeagle opened this issue Feb 13, 2016 · 9 comments
Assignees

Comments

@alexeagle
Copy link
Contributor

The paths passed to getScriptSnapshot now all appear absolute, so we cannot resolve paths (eg. rxjs and .d.ts files in our sources)

@alexeagle
Copy link
Contributor Author

FYI @IgorMinar our typescript_next build is disabled on Travis due to this issue. I don't have time to work on this right now.

@alexeagle
Copy link
Contributor Author

Actually it seems this problem also blocks Angular moving to the current release of TypeScript:
https://travis-ci.org/angular/angular/jobs/112191616

We need a broccolli maintainer

@mprobst
Copy link
Contributor

mprobst commented Apr 8, 2016

@IgorMinar @vikerman what's the status of this? I'd be very nice if we could move forward here, this blocks adopting ts2dart v0.8.

@alexeagle
Copy link
Contributor Author

Igor and Chuck have some PRs pending, I think they will land today, getting
angular2 on TS 1.8.
I'd like to get to TS 1.9 but we need to lower the output .d.ts files to
1.8-compatible; TS is putting 'readonly' modifiers in there.

On Fri, Apr 8, 2016 at 2:27 AM Martin Probst notifications@github.com
wrote:

@IgorMinar https://github.com/IgorMinar @vikerman
https://github.com/vikerman what's the status of this? I'd be very nice
if we could move forward here, this blocks adopting ts2dart v0.8.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#7050 (comment)

@IgorMinar
Copy link
Contributor

@mprobst does ts2dart depend on 1.9 or 1.8?

On Fri, Apr 8, 2016 at 10:36 AM Alex Eagle notifications@github.com wrote:

Igor and Chuck have some PRs pending, I think they will land today, getting
angular2 on TS 1.8.
I'd like to get to TS 1.9 but we need to lower the output .d.ts files to
1.8-compatible; TS is putting 'readonly' modifiers in there.

On Fri, Apr 8, 2016 at 2:27 AM Martin Probst notifications@github.com
wrote:

@IgorMinar https://github.com/IgorMinar @vikerman
https://github.com/vikerman what's the status of this? I'd be very
nice
if we could move forward here, this blocks adopting ts2dart v0.8.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#7050 (comment)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#7050 (comment)

@mprobst
Copy link
Contributor

mprobst commented Apr 9, 2016

@mprobst does ts2dart depend on 1.9 or 1.8?

No, just 1.8 IIRC (@alexeagle will know exactly).

@alexeagle
Copy link
Contributor Author

That's correct because that's what is stable in google3.
But we will move one or the other or both to 1.9 as soon as we can.

On Sat, Apr 9, 2016, 1:45 AM Martin Probst notifications@github.com wrote:

@mprobst does ts2dart depend on 1.9 or 1.8?

No, just 1.8 IIRC (@alexeagle will know exactly).


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#7050 (comment)

@alexeagle
Copy link
Contributor Author

@chuckjaz has done most of the work fixing broccoli and angular2 to work with TS 1.9, this is almost done.

@alexeagle alexeagle self-assigned this Apr 10, 2016
alexeagle added a commit to alexeagle/angular that referenced this issue Apr 10, 2016
alexeagle added a commit to alexeagle/angular that referenced this issue Apr 10, 2016
alexeagle added a commit to alexeagle/angular that referenced this issue Apr 12, 2016
alexeagle added a commit to alexeagle/angular that referenced this issue Apr 12, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants