Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Renderer): update signatures to make RenderDebugInfo optional #8859

Closed

Conversation

terrawheat
Copy link
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Users are required to provider RenderDebugInfo for the following Renderer methods:

  • selectRootElement
  • createElement
  • createTemplateAnchor
  • createText

Additionally, args was listed as mandatory for:

  • invokeElementMethod

What is the new behavior?
All above methods have had their respective property marked as optional.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

The code does not force the user to provide RenderDebugInfo. The
current implementation lists this as a mandatory parameter. Update
the parameter to be optional.

Fixes #8466

The code does not force the user to provider `RenderDebugInfo`. The
current implementation lists this as a mandatory parameter. Update
the parameter to be optional.

Fixes angular#8466
@terrawheat terrawheat closed this May 26, 2016
@terrawheat terrawheat reopened this May 26, 2016
@mhevery mhevery closed this in b7b5678 May 26, 2016
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this pull request Jun 21, 2016
The code does not force the user to provider `RenderDebugInfo`. The
current implementation lists this as a mandatory parameter. Update
the parameter to be optional.

Fixes angular#8466

Closes angular#8859
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renderer.createElement - possibly incorrect call signature
2 participants