Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(bazel): Bazel workspace schematics (#26971)" #27202

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Nov 20, 2018

This reverts commit 41b5ea1.
Reverting this change since new feature should not be merged into patch branch.
Also cherry-picked https://github.com/angular/angular/pull/26516/commits into this PR because
patch branch is currently broken. The commit should have also gone into patch besides master.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:
    Reverting this change since new feature should not be merged into patch branch.
    Also cherry-picked https://github.com/angular/angular/pull/26516/commits into this PR because
    patch branch is currently broken. The commit should have also gone into patch besides master.

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mary-poppins
Copy link

You can preview 3a1e460 at https://pr27202-3a1e460.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a26aee9 at https://pr27202-a26aee9.ngbuilds.io/.

@mary-poppins
Copy link

You can preview baffb14 at https://pr27202-baffb14.ngbuilds.io/.

@mary-poppins
Copy link

You can preview e8f067d at https://pr27202-e8f067d.ngbuilds.io/.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker PR target: patch-only labels Nov 20, 2018
@mhevery mhevery merged commit 826afc9 into angular:7.0.x Nov 21, 2018
@kyliau kyliau deleted the 7.0.x branch November 21, 2018 18:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants