Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): ensure URL is updated after second redirect with UrlUpda… #27523

Closed

Conversation

Projects
None yet
5 participants
@jasonaden
Copy link
Contributor

commented Dec 6, 2018

…teStrategy="eager"

Navigating to a route such as /users, you may get redirected to /login. Previously, if you go then route to /users again the URL will end up showing /users after the second redirect. This only happened in UrlUpdateStrategy="eager". This is now fixed so after the second redirect, the URL shows the correct page.

Fixes #27116

@googlebot googlebot added the cla: yes label Dec 6, 2018

fix(router): ensure URL is updated after second redirect with UrlUpda…
…teStrategy="eager"

Navigating to a route such as `/users`, you may get redirected to `/login`. Previously, if you go then route to `/users` again the URL will end up showing `/users` after the second redirect. This only happened in `UrlUpdateStrategy="eager"`. This is now fixed so after the second redirect, the URL shows the correct page.

Fixes #27116
@mary-poppins

This comment has been minimized.

Copy link

commented Dec 6, 2018

@jasonaden jasonaden force-pushed the jasonaden:FW-46_early_url_cancellation branch from 75b684d to 78c9072 Dec 6, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Dec 6, 2018

@jasonaden

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2018

@alxhub

alxhub approved these changes Dec 6, 2018

Copy link
Contributor

left a comment

Reviewed in person. LGTM!

@mhevery

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

Did not merge into patch. Need a separate PR

@mhevery mhevery closed this in ad26cd6 Dec 13, 2018

mhevery added a commit that referenced this pull request Dec 14, 2018

Revert "fix(router): ensure URL is updated after second redirect with…
… UrlUpdateStrategy="eager" (#27523)"

This reverts commit ad26cd6.

@mhevery mhevery reopened this Dec 14, 2018

@mhevery

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

This PR needs to be fixed up as it breaks G3.

@jasonaden

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2018

Presubmit after fix to g3 that should allow this to pass.

@matsko matsko closed this in 07ada7f Dec 20, 2018

matsko added a commit to matsko/angular that referenced this pull request Dec 26, 2018

matsko added a commit that referenced this pull request Dec 26, 2018

jasonaden added a commit to jasonaden/angular that referenced this pull request Jan 22, 2019

Revert "revert: fix(router): ensure URL is updated after second redir…
…ect with UrlUpdateStrategy="eager" (angular#27523)"

This reverts commit eea2b0f.

alxhub added a commit that referenced this pull request Jan 22, 2019

Revert "revert: fix(router): ensure URL is updated after second redir…
…ect with UrlUpdateStrategy="eager" (#27523)" (#28300)

This reverts commit eea2b0f.

PR Close #28300

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(router): ensure URL is updated after second redirect with UrlUpda…
…teStrategy="eager" (angular#27523)

Navigating to a route such as `/users`, you may get redirected to `/login`. Previously, if you go then route to `/users` again the URL will end up showing `/users` after the second redirect. This only happened in `UrlUpdateStrategy="eager"`. This is now fixed so after the second redirect, the URL shows the correct page.

Fixes angular#27116

PR Close angular#27523

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(router): ensure URL is updated after second redirect with UrlUpda…
…teStrategy="eager" (angular#27523)

Navigating to a route such as `/users`, you may get redirected to `/login`. Previously, if you go then route to `/users` again the URL will end up showing `/users` after the second redirect. This only happened in `UrlUpdateStrategy="eager"`. This is now fixed so after the second redirect, the URL shows the correct page.

Fixes angular#27116

PR Close angular#27523

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

vetom added a commit to vetom/angular that referenced this pull request Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.