fix(router): ensure URL is updated after second redirect with UrlUpda… #27523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teStrategy="eager" Navigating to a route such as `/users`, you may get redirected to `/login`. Previously, if you go then route to `/users` again the URL will end up showing `/users` after the second redirect. This only happened in `UrlUpdateStrategy="eager"`. This is now fixed so after the second redirect, the URL shows the correct page. Fixes angular#27116
|
You can preview 75b684d at https://pr27523-75b684d.ngbuilds.io/. |
jasonaden
force-pushed
the
FW-46_early_url_cancellation
branch
from
75b684d
to
78c9072
Compare
|
You can preview 78c9072 at https://pr27523-78c9072.ngbuilds.io/. |
jasonaden
added
action: merge
|
Did not merge into patch. Need a separate PR |
mhevery
added
the
action: cleanup
|
This PR needs to be fixed up as it breaks G3. |
jasonaden
added
target: major
|
Presubmit after fix to |
jasonaden
added
merge: caretaker note
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 26, 2018
… UrlUpdateStrategy="eager" (angular#27523)
matsko
added a commit
that referenced
this pull request
Dec 26, 2018
… UrlUpdateStrategy="eager" (#27523)
jasonaden
added a commit
to jasonaden/angular
that referenced
this pull request
Jan 22, 2019
…ect with UrlUpdateStrategy="eager" (angular#27523)" This reverts commit eea2b0f.
alxhub
pushed a commit
that referenced
this pull request
Jan 22, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…teStrategy="eager" (angular#27523) Navigating to a route such as `/users`, you may get redirected to `/login`. Previously, if you go then route to `/users` again the URL will end up showing `/users` after the second redirect. This only happened in `UrlUpdateStrategy="eager"`. This is now fixed so after the second redirect, the URL shows the correct page. Fixes angular#27116 PR Close angular#27523
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
… UrlUpdateStrategy="eager" (angular#27523)" This reverts commit ad26cd6.
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…teStrategy="eager" (angular#27523) Navigating to a route such as `/users`, you may get redirected to `/login`. Previously, if you go then route to `/users` again the URL will end up showing `/users` after the second redirect. This only happened in `UrlUpdateStrategy="eager"`. This is now fixed so after the second redirect, the URL shows the correct page. Fixes angular#27116 PR Close angular#27523
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
… UrlUpdateStrategy="eager" (angular#27523)
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…ect with UrlUpdateStrategy="eager" (angular#27523)" (angular#28300) This reverts commit eea2b0f. PR Close angular#28300
vetom
pushed a commit
to vetom/angular
that referenced
this pull request
Jan 31, 2019
…ect with UrlUpdateStrategy="eager" (angular#27523)" (angular#28300) This reverts commit eea2b0f. PR Close angular#28300
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…teStrategy="eager"
Navigating to a route such as
/users, you may get redirected to/login. Previously, if you go then route to/usersagain the URL will end up showing/usersafter the second redirect. This only happened inUrlUpdateStrategy="eager". This is now fixed so after the second redirect, the URL shows the correct page.Fixes #27116