fix(router): skipLocationChange with named outlets
#28300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect with UrlUpdateStrategy="eager" (angular#27523)" This reverts commit eea2b0f.
With angular#27680, a bug was fixed where multiple redirects using `eager` URL update could cause navigation to fail. However, that fix introduced a problem where with `skipLocationChange` enabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized. This PR stores the correct `UrlTree` for reference with later navigations. It fixes the regression introdued with angular#27680. Fixes angular#28200
jasonaden
changed the title
skipLocationChange with named outlets
jasonaden
added
action: merge
matsko
approved these changes
Jan 22, 2019
alxhub
pushed a commit
that referenced
this pull request
Jan 22, 2019
With #27680, a bug was fixed where multiple redirects using `eager` URL update could cause navigation to fail. However, that fix introduced a problem where with `skipLocationChange` enabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized. This PR stores the correct `UrlTree` for reference with later navigations. It fixes the regression introdued with #27680. Fixes #28200 PR Close #28300
vetom
pushed a commit
to vetom/angular
that referenced
this pull request
Jan 31, 2019
…ect with UrlUpdateStrategy="eager" (angular#27523)" (angular#28300) This reverts commit eea2b0f. PR Close angular#28300
vetom
pushed a commit
to vetom/angular
that referenced
this pull request
Jan 31, 2019
With angular#27680, a bug was fixed where multiple redirects using `eager` URL update could cause navigation to fail. However, that fix introduced a problem where with `skipLocationChange` enabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized. This PR stores the correct `UrlTree` for reference with later navigations. It fixes the regression introdued with angular#27680. Fixes angular#28200 PR Close angular#28300
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #27680, a bug was fixed where multiple redirects using
eagerURL update could cause navigation to fail. However, that fix introduced a problem where withskipLocationChangeenabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized.This PR stores the correct
UrlTreefor reference with later navigations. It fixes the regression introdued with #27680.Fixes #28200