Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full cldr #33682

Closed
wants to merge 2 commits into from

Conversation

@doom777
Copy link
Contributor

doom777 commented Nov 8, 2019

Blocked on #33699

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Fixes #33681

What is the new behavior?

Enables all the previous locales, plus new ones as per cldr-36

Does this PR introduce a breaking change?

No, but the PR whose behavior it fixes, does

Some locales were removed, some were renamed.

@doom777 doom777 requested review from angular/dev-infra-framework as code owners Nov 8, 2019
@googlebot googlebot added the cla: yes label Nov 8, 2019
@petebacondarwin

This comment has been minimized.

Copy link
Member

petebacondarwin commented Nov 8, 2019

Nice fast work @doom777 - I was just looking at that configuration too :-)

@petebacondarwin

This comment has been minimized.

Copy link
Member

petebacondarwin commented Nov 8, 2019

Note that you must remove node_modules and reinstall for the cldr-data post install hook to run and for it to pick up the new flag from the package.json.

@doom777 doom777 referenced this pull request Nov 8, 2019
4 of 14 tasks complete
Copy link
Member

josephperrott left a comment

LGTM, thanks for doing this fix!

@josephperrott josephperrott added cla: yes and removed cla: yes labels Nov 8, 2019
Copy link
Member

IgorMinar left a comment

something fishy is going on here. we should dig into this more before merging the PR

@@ -19,17 +19,21 @@ export default [
'agq', [['a.g', 'a.k'], u, u], u,
[
['n', 'k', 'g', 't', 'u', 'g', 'd'], ['nts', 'kpa', 'ghɔ', 'tɔm', 'ume', 'ghɨ', 'dzk'],
['tsuʔntsɨ', 'tsuʔukpà', 'tsuʔughɔe', 'tsuʔutɔ̀mlò', 'tsuʔumè', 'tsuʔughɨ̂m', 'tsuʔndzɨkɔʔɔ'],
[

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Nov 8, 2019

Member

it's odd that the formatting is now different but the content is the same

This comment has been minimized.

Copy link
@petebacondarwin

petebacondarwin Nov 8, 2019

Member

Again, I have found that clang will refuse to format some files on my machine. I don't know why.

@@ -57,7 +57,8 @@ export default [
'RUR': [],
'SEK': [],
'THB': ['฿'],
'TWD': ['NT$']
'TWD': ['NT$'],
'XXX': []

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Nov 8, 2019

Member

in this case there seems to be a data change. is that expected?

This comment has been minimized.

Copy link
@petebacondarwin

This comment has been minimized.

Copy link
@doom777

doom777 Nov 9, 2019

Author Contributor

yes, data change is expected, because it is part of update from cldr33 to cldr36, where some of the files were not yet upgraded.

]
],
[['е.ә.', 'ј.е.'], u, ['ерамыздан әввәл', 'јени ера']], 1, [6, 0],
['dd.MM.yy', 'd MMM y', 'd MMMM y', 'd MMMM y, EEEE'],
['HH:mm', 'HH:mm:ss', 'HH:mm:ss z', 'HH:mm:ss zzzz'], ['{1} {0}', u, u, u],
[',', '.', ';', '%', '+', '-', 'E', '×', '', '', 'NaN', ':'],
['#,##0.###', '#,##0%', '¤ #,##0.00', '#E0'], '', 'AZN',
['#,##0.###', '#,##0%', '#,##0.00 ¤', '#E0'], '', 'AZN',

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Nov 8, 2019

Member

another suspicious data change

This comment has been minimized.

Copy link
@petebacondarwin

petebacondarwin Nov 8, 2019

Member

this could well have been a fix from when we upgraded to 36 but that didn't show up previously if this is one of the files that was missing from that previous PR.

packages/common/locales/az-Latn.ts Outdated Show resolved Hide resolved
packages/common/locales/closure-locale.ts Outdated Show resolved Hide resolved
packages/common/locales/closure-locale.ts Outdated Show resolved Hide resolved

const u = undefined;

export default [];

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Nov 8, 2019

Member

are these supposed to be empty?

This comment has been minimized.

Copy link
@petebacondarwin

petebacondarwin Nov 8, 2019

Member

Many of the extra files are empty, which is why we just concatenated them together in the "global" versions.

@josephperrott

This comment has been minimized.

Copy link
Member

josephperrott commented Nov 8, 2019

@doom777 I sorted out the cause of the Unicode replacement characters showing up, and it will be sorted out in #33699. Once we get that in, you will need to rebase this PR on it and then we can merge this in since we definitely want to have the full cldr information set.

@josephperrott

This comment has been minimized.

Copy link
Member

josephperrott commented Nov 11, 2019

@doom777 With #33699 now merged, you should be able to rebase and rerun the script to create the files without any � characters.

doom777 added 2 commits Nov 8, 2019
switching to cldr-data package resulted in
loss of some locales, since by default only core locales are loaded.
This PR adds a flag to tell cldr-data to use full locale coverage

fixes: #33681
@doom777 doom777 force-pushed the doom777:fix/fullcldr branch from e933b50 to 4a284cb Nov 11, 2019
@doom777

This comment has been minimized.

Copy link
Contributor Author

doom777 commented Nov 11, 2019

Rebasing done, @IgorMinar

Copy link
Member

josephperrott left a comment

LGTM after the rebase

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Nov 11, 2019

Thanks!

@kara kara closed this in 472641c Nov 11, 2019
kara added a commit that referenced this pull request Nov 11, 2019
PR Close #33682
kara added a commit that referenced this pull request Nov 11, 2019
switching to cldr-data package resulted in
loss of some locales, since by default only core locales are loaded.
This PR adds a flag to tell cldr-data to use full locale coverage

fixes: #33681

PR Close #33682
kara added a commit that referenced this pull request Nov 11, 2019
PR Close #33682
@doom777 doom777 deleted the doom777:fix/fullcldr branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.