fix: full cldr #33682

ghost · 2019-11-08T09:01:04Z

Blocked on #33699

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Fixes #33681

What is the new behavior?

Enables all the previous locales, plus new ones as per cldr-36

Does this PR introduce a breaking change?

No, but the PR whose behavior it fixes, does

Some locales were removed, some were renamed.

petebacondarwin · 2019-11-08T09:18:59Z

Nice fast work @doom777 - I was just looking at that configuration too :-)

petebacondarwin · 2019-11-08T09:28:36Z

Note that you must remove node_modules and reinstall for the cldr-data post install hook to run and for it to pick up the new flag from the package.json.

josephperrott

LGTM, thanks for doing this fix!

IgorMinar

something fishy is going on here. we should dig into this more before merging the PR

IgorMinar · 2019-11-08T16:36:42Z

packages/common/locales/agq.ts

@@ -19,17 +19,21 @@ export default [
  'agq', [['a.g', 'a.k'], u, u], u,
  [
    ['n', 'k', 'g', 't', 'u', 'g', 'd'], ['nts', 'kpa', 'ghɔ', 'tɔm', 'ume', 'ghɨ', 'dzk'],
-    ['tsuʔntsɨ', 'tsuʔukpà', 'tsuʔughɔe', 'tsuʔutɔ̀mlò', 'tsuʔumè', 'tsuʔughɨ̂m', 'tsuʔndzɨkɔʔɔ'],
+    [


it's odd that the formatting is now different but the content is the same

Again, I have found that clang will refuse to format some files on my machine. I don't know why.

IgorMinar · 2019-11-08T16:37:03Z

packages/common/locales/ast.ts

@@ -57,7 +57,8 @@ export default [
    'RUR': [],
    'SEK': [],
    'THB': ['฿'],
-    'TWD': ['NT$']
+    'TWD': ['NT$'],
+    'XXX': []


in this case there seems to be a data change. is that expected?

See #33682 (comment)

yes, data change is expected, because it is part of update from cldr33 to cldr36, where some of the files were not yet upgraded.

IgorMinar · 2019-11-08T16:37:14Z

packages/common/locales/az-Cyrl.ts

    ]
  ],
  [['е.ә.', 'ј.е.'], u, ['ерамыздан әввәл', 'јени ера']], 1, [6, 0],
  ['dd.MM.yy', 'd MMM y', 'd MMMM y', 'd MMMM y, EEEE'],
  ['HH:mm', 'HH:mm:ss', 'HH:mm:ss z', 'HH:mm:ss zzzz'], ['{1} {0}', u, u, u],
  [',', '.', ';', '%', '+', '-', 'E', '×', '‰', '∞', 'NaN', ':'],
-  ['#,##0.###', '#,##0%', '¤ #,##0.00', '#E0'], '₼', 'AZN',
+  ['#,##0.###', '#,##0%', '#,##0.00 ¤', '#E0'], '₼', 'AZN',


another suspicious data change

this could well have been a fix from when we upgraded to 36 but that didn't show up previously if this is one of the files that was missing from that previous PR.

packages/common/locales/az-Latn.ts

packages/common/locales/closure-locale.ts

IgorMinar · 2019-11-08T16:39:44Z

packages/common/locales/extra/ff-Latn-GW.ts

+
+const u = undefined;
+
+export default [];


are these supposed to be empty?

Many of the extra files are empty, which is why we just concatenated them together in the "global" versions.

josephperrott · 2019-11-08T22:55:41Z

@doom777 I sorted out the cause of the Unicode replacement characters showing up, and it will be sorted out in #33699. Once we get that in, you will need to rebase this PR on it and then we can merge this in since we definitely want to have the full cldr information set.

josephperrott · 2019-11-11T18:48:20Z

@doom777 With #33699 now merged, you should be able to rebase and rerun the script to create the files without any � characters.

switching to cldr-data package resulted in loss of some locales, since by default only core locales are loaded. This PR adds a flag to tell cldr-data to use full locale coverage fixes: #33681

ghost · 2019-11-11T22:43:33Z

Rebasing done, @IgorMinar

josephperrott

LGTM after the rebase

IgorMinar · 2019-11-11T23:29:06Z

Thanks!

PR Close #33682

switching to cldr-data package resulted in loss of some locales, since by default only core locales are loaded. This PR adds a flag to tell cldr-data to use full locale coverage fixes: #33681 PR Close #33682

PR Close #33682

angular-automatic-lock-bot · 2019-12-13T16:02:14Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

ghost requested review from a team as code owners November 8, 2019 09:01

googlebot added the cla: yes label Nov 8, 2019

petebacondarwin approved these changes Nov 8, 2019

View reviewed changes

petebacondarwin added area: common Issues related to APIs in the @angular/common package area: i18n action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release type: bug/fix labels Nov 8, 2019

ngbot bot modified the milestone: needsTriage Nov 8, 2019

petebacondarwin added the area: build & ci Related the build and CI infrastructure of the project label Nov 8, 2019

This was referenced Nov 8, 2019

Locale Regression: 150 locales purged #33681

Closed

i18n: global locale file root fix #33662

Closed

ghost mentioned this pull request Nov 8, 2019

Add writing direction to locale files #33556

Closed

14 tasks

josephperrott approved these changes Nov 8, 2019

View reviewed changes

josephperrott added cla: yes and removed cla: yes labels Nov 8, 2019

IgorMinar suggested changes Nov 8, 2019

View reviewed changes

josephperrott added hotlist: release-blocker state: blocked labels Nov 8, 2019

josephperrott mentioned this pull request Nov 11, 2019

fix(common): update locales data to remove � characters #33699

Closed

josephperrott removed the state: blocked label Nov 11, 2019

Ephraim added 2 commits November 11, 2019 23:52

fix: use full cldr data to support all locales

bf145c6

switching to cldr-data package resulted in loss of some locales, since by default only core locales are loaded. This PR adds a flag to tell cldr-data to use full locale coverage fixes: #33681

fix: generate the new locale files

4a284cb

josephperrott approved these changes Nov 11, 2019

View reviewed changes

IgorMinar approved these changes Nov 11, 2019

View reviewed changes

josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 11, 2019

kara closed this in 472641c Nov 11, 2019

kara pushed a commit that referenced this pull request Nov 11, 2019

fix: generate the new locale files (#33682)

942e2eb

PR Close #33682

kara pushed a commit that referenced this pull request Nov 11, 2019

fix: generate the new locale files (#33682)

72796b9

PR Close #33682

ghost deleted the fix/fullcldr branch November 12, 2019 19:48

angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: full cldr #33682

fix: full cldr #33682

ghost commented Nov 8, 2019 •

edited by petebacondarwin

petebacondarwin commented Nov 8, 2019

petebacondarwin commented Nov 8, 2019 •

edited

josephperrott left a comment

IgorMinar left a comment

IgorMinar Nov 8, 2019

petebacondarwin Nov 8, 2019

IgorMinar Nov 8, 2019

petebacondarwin Nov 8, 2019

ghost Nov 9, 2019

IgorMinar Nov 8, 2019

petebacondarwin Nov 8, 2019

IgorMinar Nov 8, 2019

petebacondarwin Nov 8, 2019

josephperrott commented Nov 8, 2019

josephperrott commented Nov 11, 2019

ghost commented Nov 11, 2019

josephperrott left a comment

IgorMinar commented Nov 11, 2019

angular-automatic-lock-bot bot commented Dec 13, 2019

fix: full cldr #33682

fix: full cldr #33682

Conversation

ghost commented Nov 8, 2019 • edited by petebacondarwin

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

petebacondarwin commented Nov 8, 2019

petebacondarwin commented Nov 8, 2019 • edited

josephperrott left a comment

Choose a reason for hiding this comment

IgorMinar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josephperrott commented Nov 8, 2019

josephperrott commented Nov 11, 2019

ghost commented Nov 11, 2019

josephperrott left a comment

Choose a reason for hiding this comment

IgorMinar commented Nov 11, 2019

angular-automatic-lock-bot bot commented Dec 13, 2019

ghost commented Nov 8, 2019 •

edited by petebacondarwin

petebacondarwin commented Nov 8, 2019 •

edited