refactor: bundle types for non-APF compiler-cli package and localize/tools entry-point #45727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upcoming module resolution variant in TypeScript that supports
ESM and NodeJS better, type definitions would also need to follow ESM
import semantics. i.e. relative type imports would need to also use
epxlicit
.js
extensions.This is rather cumbersome and also not needed for all other other
Angular libraries/packages built with APF. In APF, types are always
bundled, so the manual
.js
extension is actually not needed unlesswe start leveraging this resolution system for local development.
This commit switches two non-APF entry-points/packages to manual type
bundling (the runtime code is already bundled as well). This makes these
packages/entry-points compatible with the upcoming module resolution
(by eliding all relative imports basically)
Note: There is some type duplication in the compiler-cli package because
the package source code is not accounting for the public entry-point
layout.