Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bundle types for non-APF compiler-cli package and localize/tools entry-point #45727

Closed
wants to merge 2 commits into from
Closed

refactor: bundle types for non-APF compiler-cli package and localize/tools entry-point #45727

wants to merge 2 commits into from

Commits on Apr 22, 2022

  1. refactor: bundle types for non-APF compiler-cli package and localize/… 

    …tools entry-point

With the upcoming module resolution variant in TypeScript that supports
ESM and NodeJS better, type definitions would also need to follow ESM
import semantics. i.e. relative type imports would need to also use
epxlicit `.js` extensions.

This is rather cumbersome and also not needed for all other other
Angular libraries/packages built with APF. In APF, types are always
bundled, so the manual `.js` extension is actually not needed unless
we start leveraging this resolution system for local development.

This commit switches two non-APF entry-points/packages to manual type
bundling (the runtime code is already bundled as well). This makes these
packages/entry-points compatible with the upcoming module resolution
(by eliding all relative imports basically)

Note: There is some type duplication in the compiler-cli package because
the package source code is not accounting for the public entry-point
layout.
    @devversion
    devversion committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    1e0e69a View commit details
    Browse the repository at this point in the history

  2. fixup! refactor: bundle types for non-APF compiler-cli package and lo… 

    …calize/tools entry-point

Fix granular compiler-cli api golden tests
    @devversion
    devversion committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    72c9f9a View commit details
    Browse the repository at this point in the history