Add event_dispatch library to primitives #55077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay them when application is ready.
This commit fixes various issues that seem to cause the 17.3.x patch to be red for weeks: - Eslint checking a file for aio/tools that is not part of a tsconfig— hence an error is being reported. - Audit-web-app importing some Lighthouse APIs that aren't available under the given path. PR Close #55064
…nd visibility (#54981) This commit changes the TypeScript reflection host to: * inspect / process ES private fields. e.g. `#someField` — those are ignored right now and we would want to check them to issue diagnostics. * determine an access level of a class member. E.g. a member may be public, may be private, may be ES private, or public readonly. This can then be used in various checks later. PR Close #54981
…r APIs (#54981) An initializer API like `input`, `output`, or signal queries may not be compatible with certain access levels. E.g. queries cannot work with ES private class fields. This commit introduces a check for access levels into the initializer API recognition— enforcing that every initializer API *clearly* specifies what type of access is allowed. PR Close #54981
…ivate fields (#54981) This commit ensures that the new APIs like `input`, `model`, `output`, or signal-based queries are not accidentally used on fields that have a problematic visibility/access level that won't work. For example, queries defined using a private identifier (e.g. `#bla`) will not be accessible by the Angular runtime and therefore _dont_ work. This commit ensures: - `input` is only declared via public and protected fields. - `output` is only declared via public and protected fields. - `model` is only declared via public and protected fields. - signal queries are only declared via public, protected and TS private fields (`private` works, while `#bla` does not). Fixes #54863. PR Close #54981
…nosticError` (#54981) For `FatalDiagnosticError` we are currently hiding the `message` string field in favor of the actual TS `diagnosticMessage`. This works as expected, but makes these errors hard to debug in certain environments (e.g. Jasmine). That is because `null` is the value of `message` at runtime. We fix this by just overriding the type, like we originally intended to do. In addition, we properly render message chains in the `Error#message` field— so that these errors, when uncaught, are somewhat reasonable and can be useful. PR Close #54981
Also fixes a typo in release docs for the Firefox `zip` command. PR Close #55056
…mplate files (#55003) When the `angularOnly` option is disabled, the underlying TypeScript language service was previously used for all files including `.html` template files. This can result in incorrect responses including a large amount of invalid diagnostics for a template file. Checks have now been added to only use the Angular Language service for template files which can properly handle template files. Additionally, the check for a TypeScript file name has now been expanded to encompass all current file extension forms. PR Close #55003
The custom flatMap implementation can now be removed as Array contains a native implementation that is available for all supported Node.js versions. PR Close #55011
…links are not active (#54982) Previously, `RouterLinkActive` would only add or remove the active classes when its active state changed. This means that if you accidentally add one of the active classes to the static class attribute, it won't get removed until the link becomes active and then deactives (because the class is added at creation time and never removed until the `RouterLinkActive` state changes from active to inactive). fixes #54978 PR Close #54982
internal methods are not exposed to end users and should not be extracted. PR Close #54850
Fix some typos detected using spellchecking tools, both in documentation and in code (comments, identifiers). PR Close #55018
…ivate (#54042) This commit will fix the issue of the setting of NavigationExtras.replaceUrl being lost when returning a urlTree from a CanActivateFn. Fixes #53503 BREAKING CHANGE: When a a guard returns a `UrlTree` as a redirect, the redirecting navigation will now use `replaceUrl` if the initial navigation was also using the `replaceUrl` option. If this is not desirable, the redirect can configure new `NavigationBehaviorOptions` by returning a `RedirectCommand` with the desired options instead of `UrlTree`. PR Close #54042
…#54949) This change aligns the stability of `ComponentFixture` with that of `ApplicationRef`, preventing confusing differences between the two as more APIs start using the `PendingTasks` that may not be tracked by `NgZone`. BREAKING CHANGE: `ComponentFixture.whenStable` now matches the `ApplicationRef.isStable` observable. Prior to this change, stability of the fixture did not include everything that was considered in `ApplicationRef`. `whenStable` of the fixture will now include unfinished router navigations and unfinished `HttpClient` requests. This will cause tests that `await` the `whenStable` promise to time out when there are incomplete requests. To fix this, remove the `whenStable`, instead wait for another condition, or ensure `HttpTestingController` mocks responses for all requests. Try adding `HttpTestingController.verify()` before your `await fixture.whenStable` to identify the open requests. Also, make sure your tests wait for the stability promise. We found many examples of tests that did not, meaning the expectations did not execute within the test body. In addition, `ComponentFixture.isStable` would synchronously switch to true in some scenarios but will now always be asynchronous. PR Close #54949
Add a sentence to the `@loading` block documentation that emphasizes more that the `@loading` block will replace the `@placeholder` block once the deferred view starts loading. PR Close #54779
…change detection (#54952) This commit makes the zoneless scheduler (privately) available to applications that have ZoneJS-based change detection. This would catch any changes of interest (signal updates, `markForCheck` calls, attaching `Dirty` views) that happen outside the Angular Zone. See #53844 for additional information about why this is important. More details to come in the a future commit that makes this a public option. PR Close #54952
angular-robot
bot
added
detected: breaking change
|
GG. let me just redo this all over again |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
pullapprove
bot
added
the
requires: TGP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No current behavior.
Issue Number: N/A
What is the new behavior?
Moving new functionality for JSAction.
Does this PR introduce a breaking change?
Other information