Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Cleanup firebase build #1655

Merged
merged 4 commits into from
May 16, 2018
Merged

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 15, 2018

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

  • Since we use @firebase/* as dependencies now, firebase should only be a dev dependency (we use the development version of the lib it in the tests)
  • The typings test should use @firebase/app
  • Use the module import from @firebase/app in core

Code sample

n/a

@jamesdaniels
Copy link
Member Author

@davideast I'll cut rc.9 after we merge this.

@jamesdaniels
Copy link
Member Author

Might be related to #1647

@feryholanda

This comment has been minimized.

@jamesdaniels
Copy link
Member Author

@feryholanda I responded to your issue in #18, please keep the comments related + post general questions to StackOverflow.

Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideast davideast merged commit 92f77dc into master May 16, 2018
@davideast davideast deleted the cleanup_firebase_build branch May 16, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants