Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type in updateMetadata method. #2029

Merged
merged 5 commits into from
May 8, 2019
Merged

Type in updateMetadata method. #2029

merged 5 commits into from
May 8, 2019

Conversation

s2young
Copy link
Contributor

@s2young s2young commented Mar 19, 2019

Found a typo. You may choose to leave the old method name in place for a bit. This pull request does.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@s2young
Copy link
Contributor Author

s2young commented Mar 19, 2019

I signed it

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😦 thanks for the fix!

@jamesdaniels jamesdaniels added this to the 5.2.0 milestone Apr 30, 2019
@jamesdaniels jamesdaniels merged commit 6133296 into angular:master May 8, 2019
peterennis added a commit to peterennis/angularfire2 that referenced this pull request May 9, 2019
fix(storage): Typo in updateMetadata method (angular#2029)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants