fix(): SSR memory leaks #2294
fix(): SSR memory leaks #2294
Conversation
* chore: allow passsing Scheduler to fromRef This follows a convention from RxJS where observable creators allow passing a scheduler (e.g. fromPromise, of, empty, ...) Setting the default scheduler to asyncScheduler has the same effect as the delay(0) which is why it was removed. * fix: fix memory leak in SSR * fix(universal-test): bring back universal-test app * fix: use macrotask * fix: schedule completed and error notifications in the specified scheduler And add tests to verify behavior * chore: update misleading comment * fix(typings): don't type ZoneScheduler.delegate to support old TS versions * fix(keepUnstableUntilFirst): multicast only after rescheduling BREAKING: fromRef() observables are no longer multicasted by default * fix(keepUnstableUntilFirst): schedule emissions inside of angular synchronously, invoke zone task if unsubscribed before first emission Co-authored-by: James Daniels <james@jamesdaniels.net>
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
FYI wrapping this up here @kamshak. Will merge today and cut in the next release. Thanks for your hard work here! |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
1 similar comment
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Co-authored-by: Valentin Funk <funk.valentin@gmail.com>
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
Code sample