Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-autocomplete): only animate along y axis #21588

Merged
merged 1 commit into from
Mar 5, 2021
Merged

fix(material-experimental/mdc-autocomplete): only animate along y axis #21588

merged 1 commit into from
Mar 5, 2021

Conversation

crisbeto
Copy link
Member

Changes the panel animation to only animate vertically, rather than along both x and y axis.

For reference, this is the before:
demo-current

This is after:
demo

@crisbeto
fix(material-experimental/mdc-autocomplete): only animate along y axis
b851a15 
Changes the panel animation to only animate vertically, rather than along both x and y axis.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent blocked This issue is blocked by some external factor, such as a prerequisite PR target: patch This PR is targeted for the next patch release labels Jan 14, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 14, 2021
@crisbeto
Copy link
Member Author

Blocked on verification from the MDC team.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Feb 25, 2021
@annieyw annieyw merged commit 40cce76 into angular:master Mar 5, 2021
annieyw pushed a commit that referenced this pull request Mar 5, 2021
@crisbeto @annieyw
fix(material-experimental/mdc-autocomplete): only animate along y axis (
627b0eb 
#21588)

Changes the panel animation to only animate vertically, rather than along both x and y axis.

(cherry picked from commit 40cce76)
This was referenced Mar 11, 2021
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced Mar 18, 2021
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @annieyw