Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/a11y): allow focus options to be passed in to focus trap #21769

Merged
merged 1 commit into from
Feb 5, 2021
Merged

feat(cdk/a11y): allow focus options to be passed in to focus trap #21769

merged 1 commit into from
Feb 5, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 2, 2021

Allows for an optional FocusOptions object to be passed into the various focus trap methods.

Fixes #21767.

@crisbeto
feat(cdk/a11y): allow focus options to be passed in to focus trap
c50e98a 
Allows for an optional `FocusOptions` object to be passed into the various focus
trap methods.

Fixes angular#21767.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Feb 2, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 2, 2021
mmalerba
mmalerba approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 2, 2021
@annieyw annieyw merged commit d7db7c8 into angular:master Feb 5, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
feat(cdk/a11y): allow focus options to be passed in to focus trap (an…
1c6636a 
…gular#21769)

Allows for an optional `FocusOptions` object to be passed into the various focus
trap methods.

Fixes angular#21767.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
feat(cdk/a11y): allow focus options to be passed in to focus trap (an…
abc8eec 
…gular#21769)

Allows for an optional `FocusOptions` object to be passed into the various focus
trap methods.

Fixes angular#21767.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(FocusTrap): focus methods should accept focus options
3 participants
@crisbeto @mmalerba @annieyw