fix(material/tree): aria-expanded attribute should not appear in the leaf node #29095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give us the flexibility we need to implement M3 chips
…ctor (angular#28517) Because the element selector is: - at least as much semantically correct as the div used until now - more expressive - by far the most used in this repository - the only selector explicitly mentioned on https://material.angular.io/components/dialog/overview#dialog-content
Because the vast majority of pages will already have an `<h1>`, and MDN now recommends to avoid using multiple `<h1>` elements on one page. So we should strive to show code examples that can be copy-pasted as is. See also: - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements#avoid_using_multiple_h1_elements_on_one_page - https://stackoverflow.com/a/38467898/37706 - https://accessibleweb.com/question-answer/how-should-i-handle-headings-in-a-modal/
Fixes that `mat-option` was inheriting its background color from the MDC list which led to issues in M3. The option should always have the same background as its container.
Aligns the autocomplete with the M3 spec by tokenizing the elevation and container shape.
Fixes the spacing between buttons in the dev app toolbar.
…ar#28518) Aligns the sidenav styles with the M3 spec.
* fix(material/slide-toggle): boilerplate for m3 custom tokens * create a custom-tokens function * set up theme mixins to create custom token values * create an m2 mat- tokens file * added a new namespace in _m3-tokens.scss * appended the new tokens to m2-tokens-from-theme * fix(material/slide-toggle): fix m3 width, height, and margin
…ur M3 dev-app styles with our M2 dev-app styles (angular#28516) * fix(material/theming): Fix M3 theme reliance on legacy theme inspection API * test: Align M3 demo styles more closely with M2 demo styles In particular, call the `all-component` mixins rather than individual mixins. * test: Allow toggling color API back compat CSS in the demo app
* fix(material/select): m3 native select invalid arrow color * fix(material/select): m3 option background color * fix(material/select): m3 box-shadow * fixup! fix(material/select): m3 box-shadow
* fix(material/chips): Tokenize the selected state This will give us the flexibility we need to implement M3 chips * more fixes * trailing icon state * fix test * fix some disabled states * Undo trailing icon changes * only apply disabled checkmark opacity when selected
* fix(material/slide-toggle): m3 slide-toggle track * fixup! fix(material/slide-toggle): m3 slide-toggle track
…archy (angular#28540) * fix(material-experimental/theming): Make M3 work with typography-hierarchy * test: Add tests for M3 typography hierarchy
Fix typo in cdk/scrolling documentaiton. Fix angular#28544
Specifically it should: 1. Only emit styles under the user specified selector 2. Only emit CSS variable definitions
This appears to be a regression from angular#27862 where the `preventDefault` was removed both from space and enter presses. We still need it on space so that the page doesn't scroll. Fixes angular#28392.
…ngular#28541) Fixes that the icon the menu item was collapsing if the menu item text was too long. Fixes angular#28502.
…ngular#28531) The buggy logic was using a truthiness check for checking for presence in a list, but this check needed to compare against -1 instead. This corrects a mismanagement of tabIndex on the items in the selection list: if the list of items changed, the selection list could not be tab selected until the selection list was mouse-focused.
Fixes that the table was throwing an error if all outlets are assigned before `ngAfterContentInit`. Fixes angular#28538.
* feat(google-maps): add advanced marker This commit introduces the advanced-marker feature to the map package, enabling users to add custom, interactive markers to their maps. Related angular#25897 * feat(google-maps): remove default value for mapId and correct z-index description property for advanced markers * feat(google-maps): generate api report file for google-maps
Add example of line scenarios with checkbox.
List component: tokenize space on left and right of leading icon. Correct spacing around leading icon on M3. Currently, leading icon has 16px margin in front of icon and 32px behind. Give leading icon symmetrical margin for M3. Does not intend to make visual change to M2.
Separates out the custom M3 tokens into different files so they're easier to manage.
…iles Splits up our processing of MDC's tokens into separate files so they're a bit more manageable.
…ng (angular#28968) * fix(cdk/scrolling): fix virtual scrolling jankiness with run coalescing This reverts commit ee9abb8. * fix(cdk/scrolling): Move setting transform outside `afterNextRender`
angular#28980) Fixes that the `showPopover` call was being minified by Closure and preventing the popover from opening.
… mode (angular#28979) Fixes that the M3 slide toggle didn't have an outline when it's selected in high contrast mode.
After angular#28945 the preview is inserted into a `popover` element which has a user agent styling of `color: canvastext`. These changes reset it to `inherit` to match the old behavior. Fixes angular#28974.
Switches back to positioning the preview directly instead of using a wrapper which can be breaking for existing apps. Instead we load a stylesheet dynamically with the necessary resets.
Adds an example that shows how to drag and drop table rows
…lar#28996) Fixes that the icon button anchor was using the base button template instead of the icon button one. Fixes angular#28990.
…d of a multiselect prompt in M3 theme schematic (angular#28997)
Remaps some of the tokens so that the `highlighted` input can work in M3. Fixes angular#28923.
Updates the repo to the v18 RC. Also had to bump the build tooling package to resolve some errors.
) Adds an injection token that allows users to configure the scroll strategy of a CDK menu. Fixes angular#28965.
Mitigates a compile time regression when generating M3 themes. These changes reduce the compilation time in half by caching the dummy theme instead of recreating it for each invocation. We can get away with this since the dummy theme is constant. Although these changes are a significant improvement, there's more room for improvement. Timings for reference: At head: ``` M2 benchmark - 35s M3 benchmark - 90s Theme from angular#28971 - 19s ``` After these changes changes: ``` M2 benchmark - 36s M3 benchmark - 56s Theme from angular#28971 - 10s ``` Relates to angular#28971.
…changes (angular#29000) This commit fixes an error in the tooltip component where it updates a value used in a host binding without calling `markForCheck`. This does not currently throw an error because `checkNoChanges` is broken for `OnPush` components. However, the error was surfaced when testing an "exhaustive" check that will check _all_ views, regardless of their dirty state. The issue also doesn't really produce a _visible_ problem because it occurs when the tooltip is hidden so the fact that the zoom never updates doesn't make a real difference.
…ngular#29021) Temporarily force the local spawn strategy for building during release due to seeing unexpected and yet to be traced failures in the Sass compiler within workers.
…29015) Fixes the following issues that prevented the button ripples from being loaded in the shadow DOM: * We weren't resolving the event target properly. * We were using `click` as a fallback which happens too late for the very first ripple. These changes switch to `mousedown`. Fixes angular#29011.
… node fixed an issue where aria-expanded attribute was wrongly being added to leaf nodes Fixes angular#21922
angular-robot
bot
added
detected: breaking change
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue to where leaf nodes were wrongly being assigned the aria-expanded attribute, which could confuse screen reader users.
Fixes #21922