Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

feat(autocomplete): add md-input-class binding. #11102

Merged
merged 1 commit into from
Mar 29, 2018
Merged

feat(autocomplete): add md-input-class binding. #11102

merged 1 commit into from
Mar 29, 2018

Conversation

VictorioBerra
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:

What is the new behavior?

Works similarly to the md-menu-class binding.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

#10769 (comment)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Jan 30, 2018
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Jan 30, 2018
@Splaktar Splaktar added P5: nice to have These issues will not be fixed without community contributions. type: feature needs: review This PR is waiting on review from the team labels Feb 2, 2018
@Splaktar Splaktar added this to the 1.1.8 milestone Feb 2, 2018
@Splaktar Splaktar self-assigned this Feb 2, 2018
@Splaktar Splaktar self-requested a review February 2, 2018 07:24
@Splaktar Splaktar added the needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved label Mar 16, 2018
Splaktar
Splaktar approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@Splaktar Splaktar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! It LGTM. Just needs one minor doc improvement. Please rebase as well.

src/components/autocomplete/js/autocompleteDirective.js Outdated
@@ -103,6 +103,7 @@ angular
* @param {boolean=} md-autoselect If set to true, the first item will be automatically selected
* in the dropdown upon open.
* @param {string=} md-menu-class This will be applied to the dropdown menu for styling
* @param {string=} md-input-class This will be applied to the input for styling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a note that this attribute is only valid when a md-floating-label is defined?

Copy link
Contributor Author

@VictorioBerra VictorioBerra Mar 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this:

This will be applied to the input for styling. This attribute is only valid when a md-floating-label is defined.

@Splaktar Splaktar removed the needs: review This PR is waiting on review from the team label Mar 16, 2018
@Splaktar Splaktar modified the milestones: 1.1.8, 1.1.9 Mar 16, 2018
@Splaktar Splaktar added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Mar 16, 2018
@VictorioBerra
Copy link
Contributor Author

@Splaktar rebase complete, documentation message updated.

@xr0master
Copy link

I waited the 1.1.8 version for this feature and it's not appended... Pff

@VictorioBerra
Copy link
Contributor Author

@xr0master does this mean you are waiting on me for something? What does "waited the version" mean?

@Splaktar
Copy link
Member

I think that he was just hoping that this PR got into 1.1.8.

@Splaktar Splaktar added pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved labels Mar 25, 2018
@Splaktar
Copy link
Member

Thanks for updating. Looks good! Submitted for presubmit testing.

@Splaktar Splaktar removed their assignment Mar 27, 2018
@josephperrott josephperrott merged commit 2a83967 into angular:master Mar 29, 2018
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
@VictorioBerra @chmelevskij
feat(autocomplete): add md-input-class binding. (angular#11102)
0dbf7cd
Splaktar pushed a commit that referenced this pull request Jul 31, 2018
@VictorioBerra @Splaktar
feat(autocomplete): add md-input-class binding. (#11102)
48fb8ab
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Splaktar Splaktar Splaktar approved these changes

Assignees

@Splaktar Splaktar

@josephperrott josephperrott

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P5: nice to have These issues will not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: feature
Projects
None yet
Milestone
1.1.9
Development

Successfully merging this pull request may close these issues.
6 participants
@VictorioBerra @googlebot @xr0master @Splaktar @josephperrott @LordZeroHour