Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(ripple): cleanup ripple even when the touch is very quick on iOS #11302

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

jpike88
Copy link
Contributor

@jpike88 jpike88 commented May 29, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Issue Number: #11069
http://streaka.testing.videos.s3.amazonaws.com/screencast_2018-05-29_14-38-08.mp4

What is the new behavior?

Issue doesn't occur anymore, seems fine

Does this PR introduce a breaking change?

  • No

Other information

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label May 29, 2018
@jpike88
Copy link
Contributor Author

jpike88 commented May 29, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels May 29, 2018
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I just had one minor piece of feedback on the code.

Additionally, in order to merge this, we'll need the commit message to be updated to follow our commit guidelines as indicated in the first checkbox of the PR 😉 This is needed so that we can generate a proper Changelog to let people know about this fix 😃

@@ -280,7 +280,9 @@ InkRippleCtrl.prototype.handleMousedown = function (event) {
* mouseup, touchend or mouseleave event)
*/
InkRippleCtrl.prototype.handleMouseup = function () {
autoCleanup(this, this.clearRipples);
setTimeout(function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use this.$timeout instead of setTimeout directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks the CI tests, any idea on why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't due to your change. There is a problem running tests against the latest AngularJS SNAPSHOT. We're investigating now. Thanks for the quick update!

@Splaktar Splaktar added this to the 1.1.10 milestone Jun 6, 2018
@Splaktar Splaktar added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Jun 6, 2018
@Splaktar Splaktar self-assigned this Jun 6, 2018
@Splaktar Splaktar added type: bug P4: minor Minor issues. May not be fixed without community contributions. ui: mobile ui: ink os: iOS This issue is specific to iOS labels Jun 6, 2018
@Splaktar Splaktar changed the title fixes #11069 fix(ripple): cleanup ripple even when the touch is very quick on iOS Jun 6, 2018
@jpike88 jpike88 closed this Jun 6, 2018
@jpike88 jpike88 reopened this Jun 6, 2018
@jpike88 jpike88 changed the title fix(ripple): cleanup ripple even when the touch is very quick on iOS @jpike88 fix(ripple): fix iOS Safari stuck ripple issue … this issue sometimes occurred when md-button with ripple was tapped repeatedly Fixes #11069 Jun 6, 2018
@jpike88 jpike88 changed the title @jpike88 fix(ripple): fix iOS Safari stuck ripple issue … this issue sometimes occurred when md-button with ripple was tapped repeatedly Fixes #11069 fix(ripple): cleanup ripple even when the touch is very quick on iOS Jun 6, 2018
this issue sometimes occurred when md-button with ripple was tapped repeatedly

Fixes angular#11069
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Jun 6, 2018
@Splaktar Splaktar assigned andrewseguin and jelbourn and unassigned andrewseguin Jun 6, 2018
@jelbourn jelbourn merged commit 5284145 into angular:master Jun 22, 2018
Splaktar pushed a commit that referenced this pull request Jul 31, 2018
this issue sometimes occurred when md-button with ripple was tapped repeatedly

Fixes #11069
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ os: iOS This issue is specific to iOS P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ui: ink ui: mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants