Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schematics): toolbar in nav w/o z-index causes issues with dashboard #13270

Merged
merged 1 commit into from
Sep 25, 2018
Merged

fix(schematics): toolbar in nav w/o z-index causes issues with dashboard #13270

merged 1 commit into from
Sep 25, 2018

Conversation

Splaktar
Copy link
Member

without this z-index, scrolling a dashboard causes issues

  • headers and background scroll under toolbar
  • cards scroll over top of the toolbar

@Splaktar
fix(schematics): toolbar in nav w/o z-index causes issues with dashboard
c1b809d 
without this z-index, scrolling a dashboard causes issues
- headers and background scroll under toolbar
- cards scroll over top of the toolbar
@Splaktar Splaktar added the target: major This PR is targeted for the next major release label Sep 23, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 23, 2018
devversion
devversion approved these changes Sep 23, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This seems to only happen sometimes, but a z-index is reasonable I guess.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 23, 2018
jelbourn
jelbourn approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit d74e38c into master Sep 25, 2018
@Splaktar Splaktar deleted the fixNavToolbarZIndex branch September 25, 2018 18:08
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@Splaktar @roboshoes
fix(schematics): toolbar in nav w/o z-index causes issues with dashbo…
93f5972 
…ard (angular#13270)

Without this z-index, scrolling a dashboard causes issues
- headers and background scroll under toolbar
- cards scroll over top of the toolbar
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Splaktar @jelbourn @devversion @googlebot